Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-gateway: Add event type to event parameters #235

Closed
discordianfish opened this issue Mar 18, 2019 · 0 comments · Fixed by #236
Closed

github-gateway: Add event type to event parameters #235

discordianfish opened this issue Mar 18, 2019 · 0 comments · Fixed by #236

Comments

@discordianfish
Copy link
Contributor

I want to run workflows/steps conditionally on the event type of a webhook.

The github-gateway adds a webhook for all events and passes the incoming webhook body as-is to the sensor. Unfortunately the github api doesn't return the type of the webhook in the body but only as http header: https://developer.github.com/webhooks/#delivery-headers
This means there is no well known name to distinguish between events.

We should add a event-type field to the message. The only way I see is to unmarshal the body in the gateway, add a new field and unmarshal it again. Is there a better way?

VaibhavPage pushed a commit that referenced this issue Mar 18, 2019
juliev0 pushed a commit to juliev0/argo-events that referenced this issue Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant