Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Start benefits branch #10
base: main
Are you sure you want to change the base?
feat: Start benefits branch #10
Changes from all commits
836b703
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had the discussion to start with a conservative approach to not allow Argo name including Acme Argo CD or similar, but only give out the certification badge as the stage one benefits target. The idea is to let stage one sort out all the logistics and collect the feedback before we are giving out more marketing and branding things. The concern is the fact that is easy to give out and very hard and time-consuming to take something back. If things are working great with traction and good operational experience. We will work on stage two to give out the additional benefits including Acme Argo CD usage. I believe this approach is more rational and easier to win over the majority of support from all the maintainers to move forward with the conformance plan.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jessesuen to review with @wanghong230 This is ultimately a question of if we believe the requirements are strong enough. I think with @jessesuen 's additions they are but let's discuss and try to resolve in the next week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel we are betting on things that will just work magically without gotchas, and won’t take the conservative approach. The benefits are easy to change and update afterward. The hard work is still behind that. What is the process (who, when, how) to enforce the violation? Whether are there bad gaps in our requirements? If we found something, how do we cover that gap and ask everyone to comply with that new requirement? I am not hearing the solid practices and experience about it. I vaguely have the idea that Henrik can help escalate to CNCF's particular email to enforce. I am not convinced about the process, so I believe the benefits are too generous here as the starting point.
Regarding the counter-argument with the examples:
@jessesuen @hblixt @todaywasawesome @alexec @wtam2018 @edlee2121