fix: project filter (#9651) #9709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <[email protected]>
crenshaw-dev
added
the
cherry-pick/2.4
Codecov Report
@@ Coverage Diff @@
## master #9709 +/- ##
=======================================
Coverage 45.78% 45.78%
=======================================
Files 226 226
Lines 26713 26713
=======================================
Hits 12231 12231
Misses 12818 12818
Partials 1664 1664 Continue to review full report at Codecov.
|
leoluz
approved these changes
Jun 17, 2022
10 tasks
|
Ah yes. That was the piece I was missing :-). Tested this change and it works. LGTM. |
keithchong
approved these changes
Jun 17, 2022
crenshaw-dev
added a commit
that referenced
this pull request
Jun 21, 2022
Signed-off-by: Michael Crenshaw <[email protected]>
|
Cherry-picked onto release-2.4 for 2.4.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9651
The query param for the initial list was correct. But the subsequent watch was not, so server-side filtering wasn't applied.
The break occurred when the field name changed in the gRPC upgrade: https://github.com/argoproj/argo-cd/pull/8929/files#diff-3305434591ea185f5c784bb266fe01e0500e99e0ee76952a566d7f1f8b8b6489R46
Thanks to @keithchong for pointing out that it looked like server-side filtering wasn't working!