Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove obsolete repo-server unit test #9559

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented Jun 1, 2022

Signed-off-by: Alexander Matyushentsev [email protected]

PR removes obsolete repo server test. Concurrent helm templating is already covered in e2e tests

@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #9559 (ba30603) into master (5edaa6c) will decrease coverage by 0.15%.
The diff coverage is 40.38%.

@@            Coverage Diff             @@
##           master    #9559      +/-   ##
==========================================
- Coverage   45.86%   45.71%   -0.16%     
==========================================
  Files         221      222       +1     
  Lines       26309    26380      +71     
==========================================
- Hits        12067    12059       -8     
- Misses      12586    12673      +87     
+ Partials     1656     1648       -8     
Impacted Files Coverage Δ
controller/appcontroller.go 52.07% <0.00%> (-0.21%) ⬇️
util/argo/managedfields/parser.go 100.00% <ø> (ø)
util/app/discovery/discovery.go 40.27% <33.33%> (ø)
util/argo/managedfields/managed_fields.go 42.04% <36.61%> (-32.96%) ⬇️
cmpserver/plugin/plugin.go 49.28% <50.00%> (+1.80%) ⬆️
controller/state.go 73.64% <50.00%> (-0.26%) ⬇️
controller/sync.go 56.84% <50.00%> (-0.12%) ⬇️
util/argo/diff/diff.go 52.20% <60.00%> (-0.07%) ⬇️
reposerver/repository/repository.go 60.44% <66.66%> (-0.97%) ⬇️
util/helm/helm.go 42.66% <0.00%> (-18.67%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61f48d5...ba30603. Read the comment docs.

@alexmt alexmt force-pushed the obsolete-repo-test branch from 84957da to 1884319 Compare June 1, 2022 21:02
Signed-off-by: Alexander Matyushentsev <[email protected]>
@alexmt alexmt force-pushed the obsolete-repo-test branch from 1884319 to ba30603 Compare June 1, 2022 21:07
@alexmt alexmt enabled auto-merge (squash) June 1, 2022 21:37
@alexmt alexmt merged commit fc3c5fb into argoproj:master Jun 1, 2022
@alexmt alexmt deleted the obsolete-repo-test branch June 1, 2022 22:00
@crenshaw-dev crenshaw-dev added the cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch label Jun 3, 2022
crenshaw-dev pushed a commit that referenced this pull request Jun 3, 2022
@crenshaw-dev
Copy link
Member

Cherry-picked onto 2.4.

@crenshaw-dev crenshaw-dev added the cherry-pick/2.3 Candidate for cherry picking into the 2.3 release branch label Jun 13, 2022
@crenshaw-dev
Copy link
Member

Cherry-picked onto 2.3.

crenshaw-dev pushed a commit that referenced this pull request Jun 13, 2022
@crenshaw-dev crenshaw-dev added the cherry-pick/2.2 Candidate for cherry picking into the 2.2 release branch label Jun 13, 2022
crenshaw-dev pushed a commit that referenced this pull request Jun 13, 2022
@crenshaw-dev
Copy link
Member

Cherry-picked onto 2.2.

crenshaw-dev pushed a commit that referenced this pull request Jun 14, 2022
sujeilyfonseca added a commit to sujeilyfonseca/argo-cd that referenced this pull request Jul 7, 2022
* fix(ui): Applications page incorrectly resets to tiles view. Fixes argoproj#8702 (argoproj#8718)

Signed-off-by: Yuan Tang <[email protected]>

* fix: correct jsonnet paths resolution (argoproj#8721)

Signed-off-by: Alexander Matyushentsev <[email protected]>

* chore: Bump stable version of application set addon (argoproj#8744)

Signed-off-by: Alexander Matyushentsev <[email protected]>

* fix: Retry checkbox unchecked unexpectedly; Sync up with YAML (argoproj#8682) (argoproj#8720)

Signed-off-by: Keith Chong <[email protected]>

* Bump version to 2.3.1

* Bump version to 2.3.1

* Merge pull request from GHSA-2f5v-8r3f-8pww

* fix: application resource APIs must enforce project restrictions

Signed-off-by: Alexander Matyushentsev <[email protected]>

* Fix unit tests

Signed-off-by: jannfis <[email protected]>

Co-authored-by: jannfis <[email protected]>

* chore: remove lint-docs CI task (argoproj#8722) (argoproj#8858)

* chore: remove lint-docs CI task

Signed-off-by: Alexander Matyushentsev <[email protected]>

* chore: remove not longer necessary url-allow-list

Signed-off-by: Alexander Matyushentsev <[email protected]>

Co-authored-by: Alexander Matyushentsev <[email protected]>

* chore: fix imports (argoproj#8859)

Signed-off-by: Michael Crenshaw <[email protected]>

* Bump version to 2.3.2

* Bump version to 2.3.2

* fix: Set QPS and burst rate for resource ops client (argoproj#8915)

* fix: Set QPS and burst rate for resource ops client

Signed-off-by: jannfis <[email protected]>

* fix: prevent excessive repo-server disk usage for large repos (argoproj#8845) (argoproj#8897)

fix: prevent excessive repo-server disk usage for large repos (argoproj#8845) (argoproj#8897)

Signed-off-by: Michael Crenshaw <[email protected]>

* fix: bump gitops engine version to v0.6.2

Signed-off-by: Alexander Matyushentsev <[email protected]>

* docs: update v2.4+ roadmap items (argoproj#8593)

Signed-off-by: ishitasequeira <[email protected]>

* docs: reflect v2.3 release changes in roadmap.md (argoproj#8747)

docs: reflect v2.3 release changes in roadmap.md (argoproj#8747)

Signed-off-by: Alexander Matyushentsev <[email protected]>

* Bump version to 2.3.3

* Bump version to 2.3.3

* fix: Fix docs build error (argoproj#8895)

* work with specific jinja version

Signed-off-by: pashavictorovich <[email protected]>

* fix: fix broken monaco editor collapse icons (argoproj#8709)

Signed-off-by: Alexander Matyushentsev <[email protected]>

* chore: upgrade to go 1.17.8 (argoproj#8866) (argoproj#9004)

* chore: upgrade to go 1.17.8

Signed-off-by: Michael Crenshaw <[email protected]>

* chore: use 1.17 so it's always latest in the series

Signed-off-by: Michael Crenshaw <[email protected]>

* fix: allow cli/ui to follow logs (argoproj#8987) (argoproj#9065)

Signed-off-by: Daniel Helfand <[email protected]>

* Merge pull request from GHSA-xmg8-99r8-jc2j

Signed-off-by: Michael Crenshaw <[email protected]>

Co-authored-by: Michael Crenshaw <[email protected]>

* Merge pull request from GHSA-6gcg-hp2x-q54h

* fix: do not allow symlinks from directory-type applications

Signed-off-by: Michael Crenshaw <[email protected]>

* chore: add new util file

Signed-off-by: Michael Crenshaw <[email protected]>

* chore: lint

Signed-off-by: Michael Crenshaw <[email protected]>

* chore: use t.TempDir for simpler tests

Signed-off-by: Michael Crenshaw <[email protected]>

* address comments

Signed-off-by: Michael Crenshaw <[email protected]>

* Merge pull request from GHSA-r642-gv9p-2wjj

Signed-off-by: jannfis <[email protected]>

Co-authored-by: Michael Crenshaw <[email protected]>

Co-authored-by: Michael Crenshaw <[email protected]>

* Bump version to 2.3.4

* Bump version to 2.3.4

* test: fix ErrorContains (argoproj#9445)

Signed-off-by: Michael Crenshaw <[email protected]>

* fix: missing Helm params (argoproj#9565) (argoproj#9566)

* fix: missing Helm params

Signed-off-by: Michael Crenshaw <[email protected]>

* use absolute paths, fix tests

Signed-off-by: Michael Crenshaw <[email protected]>

* fix race in test

Signed-off-by: Michael Crenshaw <[email protected]>

* chore: upgrade golangci-lint to v1.46.2 (argoproj#9448)

* chore: upgrade golangci-lint to v1.46.2

Because:

* Installation of golangci-lint v1.45.2 is currently broken and fails
  silently due to a redacted dependency
  (blizzy78/varnamelen#13)

This commit:

* Upgrades golangci-lint to v1.46.2

Signed-off-by: Tommaso Sardelli <[email protected]>

* fix: lint

Signed-off-by: Michael Crenshaw <[email protected]>

* fix: lint

Signed-off-by: Tommaso Sardelli <[email protected]>

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>

* fix: test race (argoproj#9469)

Signed-off-by: Michael Crenshaw <[email protected]>

* chore: lint issues

Signed-off-by: Michael Crenshaw <[email protected]>

* chore: update golangci-lint (argoproj#8988)

* chore: update golangci-lint

Signed-off-by: Michael Crenshaw <[email protected]>

* chore: remove obsolete repo-server unit test (argoproj#9559)

Signed-off-by: Alexander Matyushentsev <[email protected]>

* chore: Make unit tests run on platforms other than amd64 (argoproj#8995)

Signed-off-by: jannfis <[email protected]>

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>

* chore: eliminate go-mpatch dependency (argoproj#9045)

* chore: eliminate go-mpatch dependency

Signed-off-by: Michael Crenshaw <[email protected]>

* chore: abstract out resource list function

Signed-off-by: Michael Crenshaw <[email protected]>

* chore: don't exit the program in anything but the main function

Signed-off-by: Michael Crenshaw <[email protected]>

* chore: better error messages

Signed-off-by: Michael Crenshaw <[email protected]>

* chore: better error messages

Signed-off-by: Michael Crenshaw <[email protected]>

* test: directory app manifest generation (argoproj#9503)

* test: directory app manifest generation

Signed-off-by: Michael Crenshaw <[email protected]>

* git doesn't support empty dirs

Signed-off-by: Michael Crenshaw <[email protected]>

* Merge pull request from GHSA-h4w9-6x78-8vrj

Signed-off-by: Michael Crenshaw <[email protected]>

* Merge pull request from GHSA-2m7h-86qq-fp4v

Signed-off-by: Michael Crenshaw <[email protected]>

fix references

Signed-off-by: Michael Crenshaw <[email protected]>

use long enough state param for oauth2

Signed-off-by: Michael Crenshaw <[email protected]>

typo

Signed-off-by: Michael Crenshaw <[email protected]>

more entropy

Signed-off-by: Michael Crenshaw <[email protected]>

fix test

Signed-off-by: Michael Crenshaw <[email protected]>

* Merge pull request from GHSA-q4w5-4gq2-98vm

Signed-off-by: Michael Crenshaw <[email protected]>

* Merge pull request from GHSA-jhqp-vf4w-rpwq

Signed-off-by: Michael Crenshaw <[email protected]>

defer instead of multiple close calls

Signed-off-by: Michael Crenshaw <[email protected]>

oops

Signed-off-by: Michael Crenshaw <[email protected]>

don't count jsonnet against max

Signed-off-by: Michael Crenshaw <[email protected]>

fix codegen

Signed-off-by: Michael Crenshaw <[email protected]>

add caveat about 300x ratio

Signed-off-by: Michael Crenshaw <[email protected]>

fix versions

Signed-off-by: Michael Crenshaw <[email protected]>

fix tests/lint

Signed-off-by: Michael Crenshaw <[email protected]>

* chore: fix docs gen

Signed-off-by: Michael Crenshaw <[email protected]>

* Bump version to 2.3.5

* Bump version to 2.3.5

* docs: Changes for v2.3.5

Documented key decision factors to use Argo CD v2.3.5.

Contributes to: automation-saas/automation-saas/native-AWS#1972

Signed-off-by: Sujeily Fonseca <[email protected]>

Co-authored-by: Yuan Tang <[email protected]>
Co-authored-by: Alexander Matyushentsev <[email protected]>
Co-authored-by: Keith Chong <[email protected]>
Co-authored-by: argo-bot <[email protected]>
Co-authored-by: jannfis <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Co-authored-by: Ishita Sequeira <[email protected]>
Co-authored-by: pasha-codefresh <[email protected]>
Co-authored-by: Daniel Helfand <[email protected]>
Co-authored-by: Tommaso Sardelli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/2.2 Candidate for cherry picking into the 2.2 release branch cherry-pick/2.3 Candidate for cherry picking into the 2.3 release branch cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants