Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use bin mode to run e2e tests in CI #9311

Merged
merged 2 commits into from
May 5, 2022

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented May 5, 2022

Signed-off-by: Alexander Matyushentsev [email protected]

PR changes CI to use BIN_MODE to stop using go run to launch argocd components and save memory.

Closes #9308

Signed-off-by: Alexander Matyushentsev <[email protected]>
@alexmt alexmt requested a review from leoluz May 5, 2022 16:00
@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #9311 (4f2ecca) into master (d053952) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9311      +/-   ##
==========================================
+ Coverage   45.97%   46.04%   +0.06%     
==========================================
  Files         217      217              
  Lines       25903    25908       +5     
==========================================
+ Hits        11910    11929      +19     
+ Misses      12336    12321      -15     
- Partials     1657     1658       +1     
Impacted Files Coverage Δ
applicationset/services/scm_provider/github.go 75.29% <0.00%> (-5.89%) ⬇️
cmd/argocd/commands/app.go 17.98% <0.00%> (+1.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d053952...4f2ecca. Read the comment docs.

@rishabh625
Copy link
Member

rishabh625 commented May 5, 2022

@alexmt : it would also require change in test/container/Procfile as there we don't evaluate BIN_MODE and directly run go run

I have added change in this PR

Please Take a look

Makefile Outdated Show resolved Hide resolved
Signed-off-by: Alexander Matyushentsev <[email protected]>
Copy link
Collaborator

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@rishabh625 rishabh625 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tysm @alexmt

test/container/Procfile change will keep for this #9305

@alexmt alexmt enabled auto-merge (squash) May 5, 2022 17:44
@alexmt alexmt merged commit b587e0c into argoproj:master May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing E2E test due to github runner resource exhaustion
3 participants