Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ignore irrelevant moment vulnerability #9006

Merged
merged 2 commits into from
Apr 5, 2022

Conversation

crenshaw-dev
Copy link
Member

Transient dependencies prevent us from simply upgrading past this issue.

I've verified that this ignore rule works by running this locally:

snyk test --org=argoproj --all-projects --exclude=docs,site --severity-threshold=high --policy-path=.snyk

Signed-off-by: Michael Crenshaw <[email protected]>
@crenshaw-dev crenshaw-dev changed the title Ignore moment vulnerability chore: ignore irrelevant moment vulnerability Apr 5, 2022
@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #9006 (b99aade) into master (b0cd653) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9006      +/-   ##
==========================================
- Coverage   45.07%   45.03%   -0.05%     
==========================================
  Files         212      212              
  Lines       25281    25281              
==========================================
- Hits        11396    11385      -11     
- Misses      12278    12292      +14     
+ Partials     1607     1604       -3     
Impacted Files Coverage Δ
applicationset/services/scm_provider/github.go 63.52% <0.00%> (-17.65%) ⬇️
applicationset/services/scm_provider/utils.go 88.50% <0.00%> (+4.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0cd653...b99aade. Read the comment docs.

@alexmt alexmt enabled auto-merge (squash) April 5, 2022 19:23
@alexmt alexmt merged commit 5921e2a into argoproj:master Apr 5, 2022
@crenshaw-dev crenshaw-dev deleted the ignore-moment-vulnerability branch April 5, 2022 20:08
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Apr 9, 2022
* chore: ignore irrelevant moment.js vulnerability

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: asingh51 <[email protected]>
wojtekidd pushed a commit to wojtekidd/argo-cd that referenced this pull request Apr 25, 2022
* chore: ignore irrelevant moment.js vulnerability

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: wojtekidd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants