-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Correct applicationset binary name aftermerge #8954
fix: Correct applicationset binary name aftermerge #8954
Conversation
Signed-off-by: rishabh625 <[email protected]>
203b248
to
9f86828
Compare
@jannfis : Please 🙏 review this |
Codecov Report
@@ Coverage Diff @@
## master #8954 +/- ##
==========================================
+ Coverage 43.40% 44.92% +1.51%
==========================================
Files 186 212 +26
Lines 23373 25261 +1888
==========================================
+ Hits 10145 11348 +1203
- Misses 11779 12309 +530
- Partials 1449 1604 +155
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* proposal: support multiple sources for an Application Signed-off-by: ishitasequeira <[email protected]> * addressed PR comments Signed-off-by: ishitasequeira <[email protected]> * update summary Signed-off-by: ishitasequeira <[email protected]> * feat: move watch params to struct (#8819) * add to approvers Signed-off-by: pashavictorovich <[email protected]> * watch opts move to struct Signed-off-by: pashavictorovich <[email protected]> * watch opts move to struct Signed-off-by: pashavictorovich <[email protected]> Signed-off-by: ishitasequeira <[email protected]> * Merge pull request from GHSA-2f5v-8r3f-8pww * fix: application resource APIs must enforce project restrictions Signed-off-by: Alexander Matyushentsev <[email protected]> * Fix unit tests Signed-off-by: jannfis <[email protected]> Co-authored-by: jannfis <[email protected]> Signed-off-by: ishitasequeira <[email protected]> * chore: fix imports and unit tests (#8857) * chore: fix imports Signed-off-by: Michael Crenshaw <[email protected]> * chore: fix unit test Signed-off-by: Michael Crenshaw <[email protected]> * chore: keep changes minimal Signed-off-by: Michael Crenshaw <[email protected]> * chore: fix another test Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: ishitasequeira <[email protected]> * feat: operation result and history table tests (#8887) * add to approvers Signed-off-by: pashavictorovich <[email protected]> * print tables additional tests Signed-off-by: pashavictorovich <[email protected]> * move to %q Signed-off-by: pashavictorovich <[email protected]> Signed-off-by: ishitasequeira <[email protected]> * fix: corrected applicationset binary name in manifests (#8954) Signed-off-by: rishabh625 <[email protected]> Signed-off-by: ishitasequeira <[email protected]> * Update proposed design to add 'ref' field instead of externalValuesField Signed-off-by: ishitasequeira <[email protected]> * remove unwanted changes from PR added while rebase Signed-off-by: ishitasequeira <[email protected]> Co-authored-by: pasha-codefresh <[email protected]> Co-authored-by: Alexander Matyushentsev <[email protected]> Co-authored-by: jannfis <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]> Co-authored-by: rishabh625 <[email protected]>
* proposal: support multiple sources for an Application Signed-off-by: ishitasequeira <[email protected]> * addressed PR comments Signed-off-by: ishitasequeira <[email protected]> * update summary Signed-off-by: ishitasequeira <[email protected]> * feat: move watch params to struct (argoproj#8819) * add to approvers Signed-off-by: pashavictorovich <[email protected]> * watch opts move to struct Signed-off-by: pashavictorovich <[email protected]> * watch opts move to struct Signed-off-by: pashavictorovich <[email protected]> Signed-off-by: ishitasequeira <[email protected]> * Merge pull request from GHSA-2f5v-8r3f-8pww * fix: application resource APIs must enforce project restrictions Signed-off-by: Alexander Matyushentsev <[email protected]> * Fix unit tests Signed-off-by: jannfis <[email protected]> Co-authored-by: jannfis <[email protected]> Signed-off-by: ishitasequeira <[email protected]> * chore: fix imports and unit tests (argoproj#8857) * chore: fix imports Signed-off-by: Michael Crenshaw <[email protected]> * chore: fix unit test Signed-off-by: Michael Crenshaw <[email protected]> * chore: keep changes minimal Signed-off-by: Michael Crenshaw <[email protected]> * chore: fix another test Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: ishitasequeira <[email protected]> * feat: operation result and history table tests (argoproj#8887) * add to approvers Signed-off-by: pashavictorovich <[email protected]> * print tables additional tests Signed-off-by: pashavictorovich <[email protected]> * move to %q Signed-off-by: pashavictorovich <[email protected]> Signed-off-by: ishitasequeira <[email protected]> * fix: corrected applicationset binary name in manifests (argoproj#8954) Signed-off-by: rishabh625 <[email protected]> Signed-off-by: ishitasequeira <[email protected]> * Update proposed design to add 'ref' field instead of externalValuesField Signed-off-by: ishitasequeira <[email protected]> * remove unwanted changes from PR added while rebase Signed-off-by: ishitasequeira <[email protected]> Co-authored-by: pasha-codefresh <[email protected]> Co-authored-by: Alexander Matyushentsev <[email protected]> Co-authored-by: jannfis <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]> Co-authored-by: rishabh625 <[email protected]> Signed-off-by: asingh51 <[email protected]>
Signed-off-by: rishabh625 <[email protected]> Signed-off-by: wojtekidd <[email protected]>
* proposal: support multiple sources for an Application Signed-off-by: ishitasequeira <[email protected]> * addressed PR comments Signed-off-by: ishitasequeira <[email protected]> * update summary Signed-off-by: ishitasequeira <[email protected]> * feat: move watch params to struct (argoproj#8819) * add to approvers Signed-off-by: pashavictorovich <[email protected]> * watch opts move to struct Signed-off-by: pashavictorovich <[email protected]> * watch opts move to struct Signed-off-by: pashavictorovich <[email protected]> Signed-off-by: ishitasequeira <[email protected]> * Merge pull request from GHSA-2f5v-8r3f-8pww * fix: application resource APIs must enforce project restrictions Signed-off-by: Alexander Matyushentsev <[email protected]> * Fix unit tests Signed-off-by: jannfis <[email protected]> Co-authored-by: jannfis <[email protected]> Signed-off-by: ishitasequeira <[email protected]> * chore: fix imports and unit tests (argoproj#8857) * chore: fix imports Signed-off-by: Michael Crenshaw <[email protected]> * chore: fix unit test Signed-off-by: Michael Crenshaw <[email protected]> * chore: keep changes minimal Signed-off-by: Michael Crenshaw <[email protected]> * chore: fix another test Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: ishitasequeira <[email protected]> * feat: operation result and history table tests (argoproj#8887) * add to approvers Signed-off-by: pashavictorovich <[email protected]> * print tables additional tests Signed-off-by: pashavictorovich <[email protected]> * move to %q Signed-off-by: pashavictorovich <[email protected]> Signed-off-by: ishitasequeira <[email protected]> * fix: corrected applicationset binary name in manifests (argoproj#8954) Signed-off-by: rishabh625 <[email protected]> Signed-off-by: ishitasequeira <[email protected]> * Update proposed design to add 'ref' field instead of externalValuesField Signed-off-by: ishitasequeira <[email protected]> * remove unwanted changes from PR added while rebase Signed-off-by: ishitasequeira <[email protected]> Co-authored-by: pasha-codefresh <[email protected]> Co-authored-by: Alexander Matyushentsev <[email protected]> Co-authored-by: jannfis <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]> Co-authored-by: rishabh625 <[email protected]> Signed-off-by: wojtekidd <[email protected]>
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
related #8864
Correcting binary name in argocd applicationset controller manifests