Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct applicationset binary name aftermerge #8954

Merged

Conversation

rishabh625
Copy link
Member

@rishabh625 rishabh625 commented Mar 31, 2022

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

related #8864
Correcting binary name in argocd applicationset controller manifests

@rishabh625 rishabh625 force-pushed the correct-applicationset-biname-aftermerge branch from 203b248 to 9f86828 Compare March 31, 2022 11:42
@rishabh625
Copy link
Member Author

rishabh625 commented Mar 31, 2022

@jannfis : Please 🙏 review this

@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #8954 (203b248) into master (8847a31) will increase coverage by 1.51%.
The diff coverage is 63.33%.

❗ Current head 203b248 differs from pull request most recent head 9f86828. Consider uploading reports for the commit 9f86828 to get more accurate results

@@            Coverage Diff             @@
##           master    #8954      +/-   ##
==========================================
+ Coverage   43.40%   44.92%   +1.51%     
==========================================
  Files         186      212      +26     
  Lines       23373    25261    +1888     
==========================================
+ Hits        10145    11348    +1203     
- Misses      11779    12309     +530     
- Partials     1449     1604     +155     
Impacted Files Coverage Δ
applicationset/services/pull_request/fake.go 0.00% <0.00%> (ø)
applicationset/utils/createOrUpdate.go 0.00% <0.00%> (ø)
applicationset/utils/policy.go 0.00% <0.00%> (ø)
applicationset/services/pull_request/github.go 14.00% <14.00%> (ø)
...is/applicationset/v1alpha1/applicationset_types.go 34.69% <34.69%> (ø)
applicationset/generators/scm_provider.go 53.44% <53.44%> (ø)
applicationset/generators/pull_request.go 56.25% <56.25%> (ø)
...cationset/controllers/applicationset_controller.go 56.75% <56.75%> (ø)
applicationset/services/repo_service.go 57.14% <57.14%> (ø)
...licationset/generators/generator_spec_processor.go 57.57% <57.57%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e864652...9f86828. Read the comment docs.

@rishabh625 rishabh625 changed the title fix: Correct applicationset biname aftermerge fix: Correct applicationset binary name aftermerge Mar 31, 2022
Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jannfis jannfis merged commit f892110 into argoproj:master Mar 31, 2022
crenshaw-dev added a commit that referenced this pull request Apr 8, 2022
* proposal: support multiple sources for an Application

Signed-off-by: ishitasequeira <[email protected]>

* addressed PR comments

Signed-off-by: ishitasequeira <[email protected]>

* update summary

Signed-off-by: ishitasequeira <[email protected]>

* feat: move watch params to struct  (#8819)

* add to approvers

Signed-off-by: pashavictorovich <[email protected]>

* watch opts move to struct

Signed-off-by: pashavictorovich <[email protected]>

* watch opts move to struct

Signed-off-by: pashavictorovich <[email protected]>
Signed-off-by: ishitasequeira <[email protected]>

* Merge pull request from GHSA-2f5v-8r3f-8pww

* fix: application resource APIs must enforce project restrictions

Signed-off-by: Alexander Matyushentsev <[email protected]>

* Fix unit tests

Signed-off-by: jannfis <[email protected]>

Co-authored-by: jannfis <[email protected]>
Signed-off-by: ishitasequeira <[email protected]>

* chore: fix imports and unit tests (#8857)

* chore: fix imports

Signed-off-by: Michael Crenshaw <[email protected]>

* chore: fix unit test

Signed-off-by: Michael Crenshaw <[email protected]>

* chore: keep changes minimal

Signed-off-by: Michael Crenshaw <[email protected]>

* chore: fix another test

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: ishitasequeira <[email protected]>

* feat: operation result and history table tests (#8887)

* add to approvers

Signed-off-by: pashavictorovich <[email protected]>

* print tables additional tests

Signed-off-by: pashavictorovich <[email protected]>

* move to %q

Signed-off-by: pashavictorovich <[email protected]>
Signed-off-by: ishitasequeira <[email protected]>

* fix: corrected applicationset binary name in manifests (#8954)

Signed-off-by: rishabh625 <[email protected]>
Signed-off-by: ishitasequeira <[email protected]>

* Update proposed design to add 'ref' field instead of externalValuesField

Signed-off-by: ishitasequeira <[email protected]>

* remove unwanted changes from PR added while rebase

Signed-off-by: ishitasequeira <[email protected]>

Co-authored-by: pasha-codefresh <[email protected]>
Co-authored-by: Alexander Matyushentsev <[email protected]>
Co-authored-by: jannfis <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Co-authored-by: rishabh625 <[email protected]>
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Apr 9, 2022
* proposal: support multiple sources for an Application

Signed-off-by: ishitasequeira <[email protected]>

* addressed PR comments

Signed-off-by: ishitasequeira <[email protected]>

* update summary

Signed-off-by: ishitasequeira <[email protected]>

* feat: move watch params to struct  (argoproj#8819)

* add to approvers

Signed-off-by: pashavictorovich <[email protected]>

* watch opts move to struct

Signed-off-by: pashavictorovich <[email protected]>

* watch opts move to struct

Signed-off-by: pashavictorovich <[email protected]>
Signed-off-by: ishitasequeira <[email protected]>

* Merge pull request from GHSA-2f5v-8r3f-8pww

* fix: application resource APIs must enforce project restrictions

Signed-off-by: Alexander Matyushentsev <[email protected]>

* Fix unit tests

Signed-off-by: jannfis <[email protected]>

Co-authored-by: jannfis <[email protected]>
Signed-off-by: ishitasequeira <[email protected]>

* chore: fix imports and unit tests (argoproj#8857)

* chore: fix imports

Signed-off-by: Michael Crenshaw <[email protected]>

* chore: fix unit test

Signed-off-by: Michael Crenshaw <[email protected]>

* chore: keep changes minimal

Signed-off-by: Michael Crenshaw <[email protected]>

* chore: fix another test

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: ishitasequeira <[email protected]>

* feat: operation result and history table tests (argoproj#8887)

* add to approvers

Signed-off-by: pashavictorovich <[email protected]>

* print tables additional tests

Signed-off-by: pashavictorovich <[email protected]>

* move to %q

Signed-off-by: pashavictorovich <[email protected]>
Signed-off-by: ishitasequeira <[email protected]>

* fix: corrected applicationset binary name in manifests (argoproj#8954)

Signed-off-by: rishabh625 <[email protected]>
Signed-off-by: ishitasequeira <[email protected]>

* Update proposed design to add 'ref' field instead of externalValuesField

Signed-off-by: ishitasequeira <[email protected]>

* remove unwanted changes from PR added while rebase

Signed-off-by: ishitasequeira <[email protected]>

Co-authored-by: pasha-codefresh <[email protected]>
Co-authored-by: Alexander Matyushentsev <[email protected]>
Co-authored-by: jannfis <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Co-authored-by: rishabh625 <[email protected]>
Signed-off-by: asingh51 <[email protected]>
wojtekidd pushed a commit to wojtekidd/argo-cd that referenced this pull request Apr 25, 2022
wojtekidd pushed a commit to wojtekidd/argo-cd that referenced this pull request Apr 25, 2022
* proposal: support multiple sources for an Application

Signed-off-by: ishitasequeira <[email protected]>

* addressed PR comments

Signed-off-by: ishitasequeira <[email protected]>

* update summary

Signed-off-by: ishitasequeira <[email protected]>

* feat: move watch params to struct  (argoproj#8819)

* add to approvers

Signed-off-by: pashavictorovich <[email protected]>

* watch opts move to struct

Signed-off-by: pashavictorovich <[email protected]>

* watch opts move to struct

Signed-off-by: pashavictorovich <[email protected]>
Signed-off-by: ishitasequeira <[email protected]>

* Merge pull request from GHSA-2f5v-8r3f-8pww

* fix: application resource APIs must enforce project restrictions

Signed-off-by: Alexander Matyushentsev <[email protected]>

* Fix unit tests

Signed-off-by: jannfis <[email protected]>

Co-authored-by: jannfis <[email protected]>
Signed-off-by: ishitasequeira <[email protected]>

* chore: fix imports and unit tests (argoproj#8857)

* chore: fix imports

Signed-off-by: Michael Crenshaw <[email protected]>

* chore: fix unit test

Signed-off-by: Michael Crenshaw <[email protected]>

* chore: keep changes minimal

Signed-off-by: Michael Crenshaw <[email protected]>

* chore: fix another test

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: ishitasequeira <[email protected]>

* feat: operation result and history table tests (argoproj#8887)

* add to approvers

Signed-off-by: pashavictorovich <[email protected]>

* print tables additional tests

Signed-off-by: pashavictorovich <[email protected]>

* move to %q

Signed-off-by: pashavictorovich <[email protected]>
Signed-off-by: ishitasequeira <[email protected]>

* fix: corrected applicationset binary name in manifests (argoproj#8954)

Signed-off-by: rishabh625 <[email protected]>
Signed-off-by: ishitasequeira <[email protected]>

* Update proposed design to add 'ref' field instead of externalValuesField

Signed-off-by: ishitasequeira <[email protected]>

* remove unwanted changes from PR added while rebase

Signed-off-by: ishitasequeira <[email protected]>

Co-authored-by: pasha-codefresh <[email protected]>
Co-authored-by: Alexander Matyushentsev <[email protected]>
Co-authored-by: jannfis <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Co-authored-by: rishabh625 <[email protected]>
Signed-off-by: wojtekidd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants