-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add tests for app cmd #8872
Conversation
Signed-off-by: pashavictorovich <[email protected]>
Signed-off-by: pashavictorovich <[email protected]> # Conflicts: # OWNERS
Signed-off-by: pashavictorovich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great tests.
Codecov Report
@@ Coverage Diff @@
## master #8872 +/- ##
==========================================
+ Coverage 42.87% 42.93% +0.05%
==========================================
Files 186 186
Lines 23335 23359 +24
==========================================
+ Hits 10006 10029 +23
+ Misses 11898 11891 -7
- Partials 1431 1439 +8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* add to approvers Signed-off-by: pashavictorovich <[email protected]> * test filter resources in app cmd Signed-off-by: pashavictorovich <[email protected]> Signed-off-by: wojtekidd <[email protected]>
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: