Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add tests for app cmd #8872

Merged
merged 4 commits into from
Mar 23, 2022

Conversation

pasha-codefresh
Copy link
Member

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great tests.

@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #8872 (abaf320) into master (a6c664b) will increase coverage by 0.05%.
The diff coverage is 16.21%.

@@            Coverage Diff             @@
##           master    #8872      +/-   ##
==========================================
+ Coverage   42.87%   42.93%   +0.05%     
==========================================
  Files         186      186              
  Lines       23335    23359      +24     
==========================================
+ Hits        10006    10029      +23     
+ Misses      11898    11891       -7     
- Partials     1431     1439       +8     
Impacted Files Coverage Δ
cmd/argocd/commands/app.go 2.12% <0.00%> (+1.19%) ⬆️
cmd/argocd/commands/app_actions.go 0.00% <0.00%> (ø)
controller/cache/cache.go 20.76% <0.00%> (ø)
pkg/apis/application/v1alpha1/app_project_types.go 51.83% <0.00%> (-0.28%) ⬇️
server/application/application.go 31.37% <7.14%> (-0.19%) ⬇️
controller/appcontroller.go 51.61% <38.46%> (-0.21%) ⬇️
util/settings/settings.go 48.10% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af03b29...abaf320. Read the comment docs.

Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@crenshaw-dev crenshaw-dev merged commit d71cddd into argoproj:master Mar 23, 2022
wojtekidd pushed a commit to wojtekidd/argo-cd that referenced this pull request Apr 25, 2022
* add to approvers

Signed-off-by: pashavictorovich <[email protected]>

* test filter resources in app cmd

Signed-off-by: pashavictorovich <[email protected]>
Signed-off-by: wojtekidd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants