-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support swapping direction of truncation on resource names #8671
feat: support swapping direction of truncation on resource names #8671
Conversation
d6917ce
to
942e7e7
Compare
Codecov Report
@@ Coverage Diff @@
## master #8671 +/- ##
==========================================
- Coverage 45.23% 45.18% -0.05%
==========================================
Files 214 214
Lines 25420 25420
==========================================
- Hits 11498 11487 -11
- Misses 12305 12319 +14
+ Partials 1617 1614 -3
Continue to review full report at Codecov.
|
onClick={() => { | ||
toggleTitleDirection(); | ||
}} | ||
title={this.state.titleDirection ? 'Title direction right' : 'Title direction left'}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if these tooltips are more confusing than helpful. If I hadn't seen the video, the questions these tooltips would raise in my head are: What title? What's a direction in this context?
IMHO, it would be helpful if they are more concise to what will happen, such as "Truncate resource names right" and "Truncate resource names left" - but I'm also not sure on the term "resource names".
Just as something up for discussion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm definitely open to changing it if there's clearer wording, I will switch it to your suggestion for now since it's clearer than what I have at least
942e7e7
to
3be8501
Compare
ui/src/app/applications/components/application-details/application-details.tsx
Outdated
Show resolved
Hide resolved
ui/src/app/applications/components/application-details/application-details.tsx
Outdated
Show resolved
Hide resolved
ui/src/app/applications/components/application-resource-tree/application-resource-tree.scss
Outdated
Show resolved
Hide resolved
6ad98cf
to
19086a7
Compare
Signed-off-by: Regina Scott <[email protected]>
19086a7
to
3fad5b3
Compare
Hey @reginapizza , Some general points to consider:
|
Is anyone actively opposed to this change? We could always give it a try, and if people don't like it, we can try something else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a fan. We can always revert. :-)
…oproj#8671) Signed-off-by: Regina Scott <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]> Signed-off-by: wojtekidd <[email protected]>
Fixes #8560
This would add a new button to the graph options panel to toggle which direction the title of a resource is going in, allowing them to either see the beginning or end of the names only.
Checklist:
titleDirectionToggle.mp4