fix: correctly handle project field during partial cluster update #7994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7994 +/- ##
==========================================
- Coverage 41.49% 41.49% -0.01%
==========================================
Files 173 173
Lines 22576 22591 +15
==========================================
+ Hits 9369 9375 +6
- Misses 11875 11885 +10
+ Partials 1332 1331 -1
Continue to review full report at Codecov.
|
|
Just a nit, but I think you linked the wrong issue :) |
|
You are right @jannfis ! I did not read the issue description carefully. Updated description. |
Signed-off-by: Alexander Matyushentsev <[email protected]>
alexmt
force-pushed
the
7948-save-cluster-error
branch
from
0c7fa5e to
932f820
Compare
jannfis
added
the
cherry-pick/2.2
jessesuen
approved these changes
Dec 20, 2021
alexmt
pushed a commit
that referenced
this pull request
Dec 21, 2021
) Signed-off-by: Alexander Matyushentsev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Matyushentsev [email protected]
The #7039 introduced project scoped clusters support and introduced access check that ensures that user has permissions to change project. We did not take partial cluster update (using
updatedFieldsquery parameter) . The permission check should be done only is "full" update is executed or request updates "project" field.