fix: fix incorrect OCI Helm registiries assumptions

[alexmt]

Signed-off-by: Alexander Matyushentsev [email protected]

Fixes #5883
Fixes #5558
Fixes #5257

PR fixes incorrect handling of OCI Helm registries:

• Can't add apps from https://repo.chartcenter.io after upgrading from 1.7 to 1.8 #5883 Argo CD incorrectly assumes that chart is in OCI registry if it is under subdirectory. That is not correct since some OCI registries support subpaths as well. Instead of use chart path assumption should be made based on repository URL: if repository URL contains only hostname and port then it is OCI repo
• unable to pull helm charts from oci registry (InvalidSpecError) #5558 Users are struggling to register OCI registry because of scheme in the URL. PR adds explicit error message that explains that URL must include domain and port only OCI Helm repository URL should include hostname and port only
• Create App fails if repo is Helm OCI and revision is a hash #5257 Argo CD unnecessary converts non OCI and OCI charts version to semver. PR removes it for non OCI registries

[codecov]

Codecov Report

Merging #5888 (61650d2) into master (1c318f3) will increase coverage by 0.02%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##           master    #5888      +/-   ##
==========================================
+ Coverage   40.88%   40.91%   +0.02%     
==========================================
  Files         147      147              
  Lines       19619    19620       +1     
==========================================
+ Hits         8021     8027       +6     
+ Misses      10493    10489       -4     
+ Partials     1105     1104       -1     

Impacted Files	Coverage Δ
pkg/apis/application/v1alpha1/types.go	57.44% <0.00%> (ø)
util/helm/client.go	45.02% <50.00%> (+0.38%)	⬆️
reposerver/repository/repository.go	62.80% <80.00%> (+0.34%)	⬆️
util/argo/argo.go	60.75% <100.00%> (+0.88%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c318f3...61650d2. Read the comment docs.

[kshamajain99]

LGTM