-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: selective sync (#3877) #5347
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go.mod needs to be updated once the change in gitops-engine is merged.
Signed-off-by: kshamajain99 <[email protected]>
159af8c
to
e36bb5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Merging after gitops engine reference is updated to argoproj/gitops-engine#213
Signed-off-by: kshamajain99 <[email protected]>
8600f46
to
84e2099
Compare
Signed-off-by: kshamajain99 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #5347 +/- ##
==========================================
- Coverage 41.06% 41.02% -0.04%
==========================================
Files 136 136
Lines 18384 18510 +126
==========================================
+ Hits 7549 7594 +45
- Misses 9755 9832 +77
- Partials 1080 1084 +4
Continue to review full report at Codecov.
|
* selective sync Signed-off-by: kshamajain99 <[email protected]>
Signed-off-by: kshamajain99 [email protected]
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
issue: #3877
gitops-engine changes: argoproj/gitops-engine#213
This feature applies only out-of-sync resources when
ApplyOutOfSync=true
option is provided by user.Test performed:
Scenario: For an application with 10 deployments and 1 svc, deleting svc and syncing entire application (performing same action)
With
ApplyOutOfSync=true
enabledWithout
ApplyOutOfSync=true
enabled