-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): Filterable pod logs #5319
Conversation
Signed-off-by: Remington Breeze <[email protected]>
Signed-off-by: Remington Breeze <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #5319 +/- ##
==========================================
- Coverage 41.06% 41.03% -0.03%
==========================================
Files 136 136
Lines 18384 18395 +11
==========================================
Hits 7549 7549
- Misses 9755 9766 +11
Partials 1080 1080
Continue to review full report at Codecov.
|
ui/src/app/applications/components/pod-logs-viewer/pod-logs-viewer.tsx
Outdated
Show resolved
Hide resolved
ui/src/app/applications/components/pod-logs-viewer/pod-logs-viewer.tsx
Outdated
Show resolved
Hide resolved
ui/src/app/applications/components/pod-logs-viewer/pod-logs-viewer.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Remington Breeze <[email protected]>
Signed-off-by: Remington Breeze <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please React warnings:
react-dom.development.js:88 Warning: A component is changing an uncontrolled input of type text to be controlled. Input elements should not switch from uncontrolled to controlled (or vice versa). Decide between using a controlled or uncontrolled input element for the lifetime of the component. More info: https://fb.me/react-controlled-components
in input (created by DataLoader)
in div (created by DataLoader)
in div (created by DataLoader)
in DataLoader (created by PodsLogsViewer)
in PodsLogsViewer (created by DataLoader)
in div (created by DataLoader)
in div (created by DataLoader)
in div (created by DataLoader)
in div (created by Tabs)
in div (created by Tabs)
in Tabs (created by DataLoader)
in DataLoader (created by DataLoader)
in div (created by DataLoader)
in div (created by SlidingPanel)
in div (created by SlidingPanel)
in div (created by SlidingPanel)
in SlidingPanel (created by DataLoader)
in div (created by Page)
in div (created by Page)
in Page (created by DataLoader)
in DataLoader (created by Page)
in Page (created by DataLoader)
in div (created by DataLoader)
in DataLoader (created by ObservableQuery)
in ObservableQuery (created by ApplicationDetails)
in ApplicationDetails (created by Route)
in Route (created by ApplicationsContainer)
in Switch (created by ApplicationsContainer)
in ApplicationsContainer (created by Route)
in div (created by Layout)
in Layout (created by Route)
in Route (created by App)
in Switch (created by App)
in Router (created by App)
in App
printWarning @ react-dom.development.js:88
8AsyncScheduler.ts:44 Uncaught TypeError: Cannot read property 'reload' of null
at SafeSubscriber._next (pod-logs-viewer.tsx:110)
at SafeSubscriber../node_modules/rxjs/Subscriber.js.SafeSubscriber.__tryOrUnsub (Subscriber.ts:258)
at SafeSubscriber../node_modules/rxjs/Subscriber.js.SafeSubscriber.next (Subscriber.ts:208)
at Subscriber../node_modules/rxjs/Subscriber.js.Subscriber._next (Subscriber.ts:139)
at Subscriber../node_modules/rxjs/Subscriber.js.Subscriber.next (Subscriber.ts:99)
at DebounceTimeSubscriber../node_modules/rxjs/operators/debounceTime.js.DebounceTimeSubscriber.debouncedNext (debounceTime.ts:100)
at AsyncAction.dispatchNext (debounceTime.ts:118)
at AsyncAction../node_modules/rxjs/scheduler/AsyncAction.js.AsyncAction._execute (AsyncAction.ts:123)
at AsyncAction../node_modules/rxjs/scheduler/AsyncAction.js.AsyncAction.execute (AsyncAction.ts:98)
at AsyncScheduler../node_modules/rxjs/scheduler/AsyncScheduler.js.AsyncScheduler.flush (AsyncScheduler.ts:33)
DevTools failed to load SourceMap: Could not load content for http://localhost:4000/applications/ReactToastify.css.map: HTTP error: status code 404, net::ERR_HTTP_RESPONSE_CODE_FAILURE
pod-logs-viewer.tsx:110 Uncaught TypeError: Cannot read property 'reload' of null
at SafeSubscriber._next (pod-logs-viewer.tsx:110)
at SafeSubscriber../node_modules/rxjs/Subscriber.js.SafeSubscriber.__tryOrUnsub (Subscriber.ts:258)
at SafeSubscriber../node_modules/rxjs/Subscriber.js.SafeSubscriber.next (Subscriber.ts:208)
at Subscriber../node_modules/rxjs/Subscriber.js.Subscriber._next (Subscriber.ts:139)
at Subscriber../node_modules/rxjs/Subscriber.js.Subscriber.next (Subscriber.ts:99)
at DebounceTimeSubscriber../node_modules/rxjs/operators/debounceTime.js.DebounceTimeSubscriber.debouncedNext (debounceTime.ts:100)
at AsyncAction.dispatchNext (debounceTime.ts:118)
at AsyncAction../node_modules/rxjs/scheduler/AsyncAction.js.AsyncAction._execute (AsyncAction.ts:123)
at AsyncAction../node_modules/rxjs/scheduler/AsyncAction.js.AsyncAction.execute (AsyncAction.ts:98)
at AsyncScheduler../node_modules/rxjs/scheduler/AsyncScheduler.js.AsyncScheduler.flush (AsyncScheduler.ts:33)
(anonymous) @ pod-logs-viewer.tsx:110
./node_modules/rxjs/Subscriber.js.SafeSubscriber.__tryOrUnsub @ Subscriber.ts:258
./node_modules/rxjs/Subscriber.js.SafeSubscriber.next @ Subscriber.ts:208
./node_modules/rxjs/Subscriber.js.Subscriber._next @ Subscriber.ts:139
./node_modules/rxjs/Subscriber.js.Subscriber.next @ Subscriber.ts:99
./node_modules/rxjs/operators/debounceTime.js.DebounceTimeSubscriber.debouncedNext @ debounceTime.ts:100
dispatchNext @ debounceTime.ts:118
./node_modules/rxjs/scheduler/AsyncAction.js.AsyncAction._execute @ AsyncAction.ts:123
./node_modules/rxjs/scheduler/AsyncAction.js.AsyncAction.execute @ AsyncAction.ts:98
./node_modules/rxjs/scheduler/AsyncScheduler.js.AsyncScheduler.flush @ AsyncScheduler.ts:33
setInterval (async)
./node_modules/rxjs/scheduler/AsyncAction.js.AsyncAction.requestAsyncId @ AsyncAction.ts:74
./node_modules/rxjs/scheduler/AsyncAction.js.AsyncAction.schedule @ AsyncAction.ts:68
./node_modules/rxjs/Scheduler.js.Scheduler.schedule @ Scheduler.ts:61
./node_modules/rxjs/operators/debounceTime.js.DebounceTimeSubscriber._next @ debounceTime.ts:88
./node_modules/rxjs/Subscriber.js.Subscriber.next @ Subscriber.ts:99
handler @ FromEventObservable.ts:240
Signed-off-by: Remington Breeze <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* feat(ui): Filterable pod logs Signed-off-by: Remington Breeze <[email protected]>
Signed-off-by: Remington Breeze [email protected]
Fix #3455
Filters logs on server side to prevent transit of irrelevant data
Checklist: