-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Smoke test for CLI - issue4393 #4716
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@amitkrout Adding the initial files per our discussion. Please review. |
Is this ready for review? It appears to be failing linting/other tests. If not please mark as draft |
Signed-off-by: Keith Chong <[email protected]> Signed-off-by: Dewan Ahmed <[email protected]>
Signed-off-by: Dewan Ahmed <[email protected]>
* feat: Support oci-based helm repository Signed-off-by: haoshuwei <[email protected]> Signed-off-by: Dewan Ahmed <[email protected]>
* feat: Util for generate global project from ClusterRole * feat: fix lint error * feat: fix test failure * fix lint * fix lint error * moved into sub command and removed not needed fields. * updated error package * rename files Signed-off-by: Dewan Ahmed <[email protected]>
Signed-off-by: Dewan Ahmed <[email protected]>
Signed-off-by: Dewan Ahmed <[email protected]>
Signed-off-by: Dewan Ahmed <[email protected]>
Signed-off-by: Dewan Ahmed <[email protected]>
…tions (#4685) Signed-off-by: Dewan Ahmed <[email protected]>
…4677) Signed-off-by: Dewan Ahmed <[email protected]>
Signed-off-by: Dewan Ahmed <[email protected]>
Signed-off-by: Dewan Ahmed <[email protected]>
…4702) Signed-off-by: Keith Chong <[email protected]> Signed-off-by: Dewan Ahmed <[email protected]>
* feat: Improve UX when filtering applications - When application filters are active, show a badge with # filters and a button to clear them - When no matching applications are found, provide a button to clear filters - Styling updates to application filters UI Signed-off-by: Tim Etchells <[email protected]> Signed-off-by: Dewan Ahmed <[email protected]>
Signed-off-by: darshanime <[email protected]> Signed-off-by: Dewan Ahmed <[email protected]>
* fix: adding commonAnnotations optional k/v map to add annotations via kustomize * fix: adding kustomize common annotations also correcting kustomize cli flags to respect multiple options #4613 Signed-off-by: Dewan Ahmed <[email protected]>
* feat: Annnotation based app prefix detection in webhooks * webhook should copy previously generated manifests cache if new commit does not introduce any changes * use 'argocd.argoproj.io/manifest-generate-paths' annotation to specify paths Co-authored-by: Carson Anderson <[email protected]> Signed-off-by: Dewan Ahmed <[email protected]>
Signed-off-by: Dewan Ahmed <[email protected]>
Signed-off-by: Dewan Ahmed <[email protected]>
Signed-off-by: Dewan Ahmed <[email protected]>
Signed-off-by: Dewan Ahmed <[email protected]>
Signed-off-by: Dewan Ahmed <[email protected]>
…nto patch-4393 Signed-off-by: Dewan Ahmed <[email protected]>
…nto patch-4393 Signed-off-by: Dewan Ahmed <[email protected]>
Signed-off-by: Dewan Ahmed <[email protected]>
…nto patch-4393 Signed-off-by: Dewan Ahmed <[email protected]> Fixing lint errors.
Signed-off-by: Dewan Ahmed <[email protected]>
Signed-off-by: Dewan Ahmed <[email protected]> Adding initial test for issue-4393.
Signed-off-by: Dewan Ahmed <[email protected]> Date: Wed Nov 4 09:32:13 2020 -0500
Signed-off-by: Dewan Ahmed <[email protected]>
This PR is obsolete. Closing. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Background:
fixture
orRunCli
and need to write new helper functions for smoke test. discussionargocd login ....
or caller of the function will provide a token to the test script.What's done with this PR:
argocd app create
What is to be done in future:
CleanUp()
function to delete existing app from namespace and existing tests from the project.argocd app sync
andargocd app wait
tests.Assumption:
A caller of any of these smoke tests can run them for N times using Go's built-in capabilities:
go test -run <testname> -count N
Will this suffice?