Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Smoke test for CLI - issue4393 #4716

Closed
wants to merge 35 commits into from
Closed

chore: Smoke test for CLI - issue4393 #4716

wants to merge 35 commits into from

Conversation

dewan-ahmed
Copy link
Contributor

@dewan-ahmed dewan-ahmed commented Oct 30, 2020

Checklist:

Background:

  1. original issue
  2. Cannot use existing helper functions e.g. fixture or RunCli and need to write new helper functions for smoke test. discussion
  3. Expect that the session will already be authenticated by argocd login .... or caller of the function will provide a token to the test script.
  4. The test should be able to run N times which is provided by the caller. discussion
  5. The tests should run within "smoke-test" project. discussion

What's done with this PR:

  1. Creating directory structure and pkg for the smoke test.
  2. Creating RunCmd helper function
  3. Adding test for argocd app create

What is to be done in future:

  1. Adding CleanUp() function to delete existing app from namespace and existing tests from the project.
  2. Adding argocd app sync and argocd app wait tests.
  3. Adding error handling and fallback scenarios.

Assumption:

A caller of any of these smoke tests can run them for N times using Go's built-in capabilities:

go test -run <testname> -count N

Will this suffice?

@dewan-ahmed
Copy link
Contributor Author

@amitkrout Adding the initial files per our discussion. Please review.

@jessesuen
Copy link
Member

Is this ready for review? It appears to be failing linting/other tests. If not please mark as draft

@dewan-ahmed dewan-ahmed marked this pull request as draft October 30, 2020 21:47
keithchong and others added 27 commits November 2, 2020 15:22
* feat: Support oci-based helm repository

Signed-off-by: haoshuwei <[email protected]>
Signed-off-by: Dewan Ahmed <[email protected]>
* feat: Util for generate global project from ClusterRole

* feat: fix lint error

* feat: fix test failure

* fix lint

* fix lint error

* moved into sub command and removed not needed fields.

* updated error package

* rename files

Signed-off-by: Dewan Ahmed <[email protected]>
Signed-off-by: Dewan Ahmed <[email protected]>
Signed-off-by: Dewan Ahmed <[email protected]>
* feat: Improve UX when filtering applications

- When application filters are active, show a badge with # filters and a button to clear them
- When no matching applications are found, provide a button to clear filters
- Styling updates to application filters UI

Signed-off-by: Tim Etchells <[email protected]>
Signed-off-by: Dewan Ahmed <[email protected]>
Signed-off-by: darshanime <[email protected]>
Signed-off-by: Dewan Ahmed <[email protected]>
* fix: adding commonAnnotations

optional k/v map to add annotations via kustomize

* fix: adding kustomize common annotations

also correcting kustomize cli flags to respect multiple options

#4613

Signed-off-by: Dewan Ahmed <[email protected]>
* feat: Annnotation based app prefix detection in webhooks

* webhook should copy previously generated manifests cache if new commit does not introduce any changes

* use 'argocd.argoproj.io/manifest-generate-paths' annotation to specify paths

Co-authored-by: Carson Anderson <[email protected]>
Signed-off-by: Dewan Ahmed <[email protected]>
Signed-off-by: Dewan Ahmed <[email protected]>
Signed-off-by: Dewan Ahmed <[email protected]>
…nto patch-4393

Signed-off-by: Dewan Ahmed <[email protected]>

Fixing lint errors.
Signed-off-by: Dewan Ahmed <[email protected]>

Adding initial test for issue-4393.
Signed-off-by: Dewan Ahmed <[email protected]>

Date:      Wed Nov 4 09:32:13 2020 -0500
Signed-off-by: Dewan Ahmed <[email protected]>
@dewan-ahmed
Copy link
Contributor Author

This PR is obsolete. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.