Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert "fix: Graceful shutdown for the API server (#18642) (#20981)" #21221

Conversation

pasha-codefresh
Copy link
Member

No description provided.

@pasha-codefresh pasha-codefresh requested a review from a team as a code owner December 17, 2024 16:16
Copy link

bunnyshell bot commented Dec 17, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 21.42857% with 22 lines in your changes missing coverage. Please review.

Project coverage is 55.05%. Comparing base (9203dd1) to head (c1685ca).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
server/server.go 15.78% 16 Missing ⚠️
cmd/argocd-server/commands/argocd_server.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21221      +/-   ##
==========================================
+ Coverage   53.22%   55.05%   +1.83%     
==========================================
  Files         338      338              
  Lines       57164    57075      -89     
==========================================
+ Hits        30425    31423     +998     
+ Misses      24079    22958    -1121     
- Partials     2660     2694      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pasha-codefresh pasha-codefresh merged commit 46bfc10 into argoproj:master Dec 17, 2024
26 of 27 checks passed
@pasha-codefresh
Copy link
Member Author

/cherry-pick release-2.14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants