Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(applicationset): explain how to add repo credentials #20453

Merged
merged 6 commits into from
Oct 21, 2024
Merged

docs(applicationset): explain how to add repo credentials #20453

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c2b4989
docs(applicationset): add section explaining how to set up repo crede…
ruant Oct 18, 2024
500d6c0
Merge branch 'master' into patch-1
ruant Oct 21, 2024
1e072cb
Update docs/operator-manual/applicationset/Generators-Git.md
ruant Oct 21, 2024
f34407c
Update docs/operator-manual/applicationset/Generators-Git.md
ruant Oct 21, 2024
e549313
Update docs/operator-manual/applicationset/Generators-Git.md
ruant Oct 21, 2024
2e73fb5
Update docs/operator-manual/applicationset/Generators-Git.md
ruant Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/operator-manual/applicationset/Generators-Git.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,3 +443,9 @@ stringData:
```

After saving, please restart the ApplicationSet pod for the changes to take effect.

Copy link
Member

@blakepettersson blakepettersson Oct 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did add a section regarding this in the project section (for some reason it's not being displayed in the stable release 🤔), although it probably makes sense to have this in the Git generator section as well...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, look at that :)

Not sure where it should actually belong, i kinda find it weird to have under "project", since the applicationset can't belong to a project anyway.
For me it belongs under Generators-git, since that's where it will be used. But perhaps a mention directly on Applicationset is good too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy either way, I just wanted to write it down somewhere so people knew how it worked.
Up to you 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me 😄

## Repository credentials for ApplicationSets
If your [ApplicationSets](index.md) uses a repository where you need credentials to be able to access it, you need to add the repository as a "non project scoped" repository.
- When doing that through the UI, set this to a **blank** value in the dropdown menu.
- When doing that through the CLI, make sure you **DO NOT** supply the parameter `--project` ([argocd repo add docs](../../user-guide/commands/argocd_repo_add.md))
- When doing that declaratively, make sure you **DO NOT** have `project:` defined under `stringData:` ([complete yaml example](../argocd-repositories-yaml.md))