fix(controller/ui): fix pod with sidecar state (cherry-pick #19843) #20396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(controller): change pod status calculate with sidecar Signed-off-by: linghaoSu <[email protected]> * fix(controller): add restartable sidecar count in total container display Signed-off-by: linghaoSu <[email protected]> * fix(controller): update info test case conditions Co-authored-by: Michael Crenshaw <[email protected]> Signed-off-by: Linghao Su <[email protected]> * fix(controller): add more test case to cover more conditions Signed-off-by: linghaoSu <[email protected]> * fix(ui): check is condition exist before for of Signed-off-by: linghaoSu <[email protected]> --------- Signed-off-by: linghaoSu <[email protected]> Signed-off-by: Linghao Su <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>
|
@linghaoSu looks like the k8s library version is too old for this feature. Closing for now. If we feel we need the fix with older versions than 2.12, we can discuss a strategy here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(controller/ui): fix pod with sidecar state (#19843)
Signed-off-by: linghaoSu [email protected]
Signed-off-by: linghaoSu [email protected]
Co-authored-by: Michael Crenshaw [email protected]
Signed-off-by: Linghao Su [email protected]
Signed-off-by: linghaoSu [email protected]
Signed-off-by: linghaoSu [email protected]