feat: reduce redis traffic caused by app resource tree updates in redis #19722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
gdsoumya
requested changes
Aug 29, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19722 +/- ##
=========================================
Coverage ? 55.89%
=========================================
Files ? 320
Lines ? 44031
Branches ? 0
=========================================
Hits ? 24611
Misses ? 16863
Partials ? 2557 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Alexander Matyushentsev <[email protected]>
alexmt
force-pushed
the
optimize-app-tree-traffic
branch
from
7d4ec8e to
91e2088
Compare
|
@gdsoumya agree - updated the docs |
gdsoumya
approved these changes
Aug 29, 2024
blakepettersson
approved these changes
Aug 29, 2024
eogns47
pushed a commit
to eogns47/argo-cd
that referenced
this pull request
Sep 2, 2024
…is (argoproj#19722) Signed-off-by: Alexander Matyushentsev <[email protected]> Signed-off-by: KangManJoo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR reduces the amount of traffic sent from the controller to redis while updated application resource tree.
The application resource tree contains metadata of all resources that belongs to application and stored in redis. Currently, it replaces the whole resources tree in Redis every time any app resource changes. This causes exponential growth of traffic sent from the controller to Redis: the more resources the application has, the more frequently they change, and the more frequently the controller needs to update the resources tree, and the tree is bigger with each resource.
The PR allows to optionally split resources tree into shards using
ARGOCD_APPLICATION_TREE_SHARD_SIZEenv variable. IfARGOCD_APPLICATION_TREE_SHARD_SIZEis bigger then 0 then controller split app resources into shards and store each shard in a separate Redis key. When any app resource changes then only related shard is updated which significantly reduces amount of Redis traffic.