Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): could not find source for metadata revision (#18744) (cherry-pick #18763) #18782

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

gcp-cherry-pick-bot[bot]
Copy link

Cherry-picked fix(server): could not find source for metadata revision (#18744) (#18763)

Signed-off-by: Michael Crenshaw [email protected]

  • lint

Signed-off-by: Michael Crenshaw [email protected]

  • the linter behaves poorly

Signed-off-by: Michael Crenshaw [email protected]

  • fix test

Signed-off-by: Michael Crenshaw [email protected]

  • share logic with chart endpoint

Signed-off-by: Michael Crenshaw [email protected]

  • more intuitive check

Signed-off-by: Michael Crenshaw [email protected]

  • remove debug line

Signed-off-by: Michael Crenshaw [email protected]


Signed-off-by: Michael Crenshaw [email protected]

…8763)

* fix(server): could not find source for metadata revision (#18744)

Signed-off-by: Michael Crenshaw <[email protected]>

* lint

Signed-off-by: Michael Crenshaw <[email protected]>

* the linter behaves poorly

Signed-off-by: Michael Crenshaw <[email protected]>

* fix test

Signed-off-by: Michael Crenshaw <[email protected]>

* share logic with chart endpoint

Signed-off-by: Michael Crenshaw <[email protected]>

* more intuitive check

Signed-off-by: Michael Crenshaw <[email protected]>

* remove debug line

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot requested a review from a team as a code owner June 24, 2024 01:08
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.

Project coverage is 50.31%. Comparing base (fe60670) to head (f6d8a4c).
Report is 44 commits behind head on release-2.12.

Files with missing lines Patch % Lines
server/application/application.go 94.59% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-2.12   #18782      +/-   ##
================================================
+ Coverage         50.28%   50.31%   +0.03%     
================================================
  Files               312      312              
  Lines             43025    43026       +1     
================================================
+ Hits              21635    21649      +14     
+ Misses            18912    18898      -14     
- Partials           2478     2479       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev crenshaw-dev merged commit 16c20a8 into release-2.12 Jun 24, 2024
23 of 26 checks passed
@crenshaw-dev crenshaw-dev deleted the cherry-pick-afe030-release-2.12 branch June 24, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants