Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: status.sync.comparedTo should use replace patch strategy (#18061) #18077

Merged
merged 1 commit into from
May 5, 2024
Merged

fix: status.sync.comparedTo should use replace patch strategy (#18061) #18077

merged 1 commit into from
May 5, 2024

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented May 4, 2024

  • fix: status.sync.comparedTo should use replace patch strategy

  • add e2e tests

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@alexmt
fix: status.sync.comparedTo should use replace patch strategy (argopr…
6ac4cda 
…oj#18061)

* fix: status.sync.comparedTo should use replace patch strategy

Signed-off-by: Alexander Matyushentsev <[email protected]>

* add e2e tests

Signed-off-by: Alexander Matyushentsev <[email protected]>

---------

Signed-off-by: Alexander Matyushentsev <[email protected]>
gdsoumya
gdsoumya approved these changes May 5, 2024
View reviewed changes
Copy link
Member

@gdsoumya gdsoumya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit bc54c76 into argoproj:release-2.8 May 5, 2024
14 of 19 checks passed
@alexmt alexmt deleted the cherry-pick-status-patch-2.8 branch May 5, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdsoumya gdsoumya gdsoumya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexmt @gdsoumya