Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Mention configmap to enable new git file globbing by name #17936

Merged
merged 1 commit into from
Apr 23, 2024
Merged

docs: Mention configmap to enable new git file globbing by name #17936

merged 1 commit into from
Apr 23, 2024

Conversation

ChristianCiach
Copy link
Contributor

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@ChristianCiach ChristianCiach requested review from a team as code owners April 23, 2024 11:19
@ChristianCiach
Copy link
Contributor Author

This only adds a small clarification to the docs, so I guess most points of the issue template do not apply.

Please let me know if there is something wrong with this PR. Otherwise I will probably create some more PRs of this type in the near future.

I am new to ArgoCD, so some parts of the docs are not immediately clear to me as a first-time reader. This PR addresses one of these cases, because "the Argo CD ConfigMap" is too ambiguous, which lead me to change the argocd-cm ConfigMap at first.

crenshaw-dev
crenshaw-dev approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ChristianCiach!

@crenshaw-dev crenshaw-dev merged commit 634645f into argoproj:master Apr 23, 2024
23 checks passed
@crenshaw-dev
Copy link
Member

/cherry-pick release-2.11

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Apr 23, 2024
@ChristianCiach
docs: Mention configmap to enable new git file globbing by name (#17936)
9047407 
Signed-off-by: Christian Ciach <[email protected]>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Apr 23, 2024
Closed
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Apr 23, 2024
@ChristianCiach
docs: Mention configmap to enable new git file globbing by name (#17936)
718bd19 
Signed-off-by: Christian Ciach <[email protected]>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Apr 23, 2024
Merged
crenshaw-dev pushed a commit that referenced this pull request Apr 23, 2024
@gcp-cherry-pick-bot @ChristianCiach
docs: Mention configmap to enable new git file globbing by name (#17936…
fb573e0 
…) (#17938)

Signed-off-by: Christian Ciach <[email protected]>
Co-authored-by: ChristianCiach <[email protected]>
@ChristianCiach ChristianCiach deleted the patch1 branch April 23, 2024 14:31
mkieweg pushed a commit to mkieweg/argo-cd that referenced this pull request Jun 11, 2024
@ChristianCiach @mkieweg
docs: Mention configmap to enable new git file globbing by name (argo…
4cb311b 
…proj#17936)

Signed-off-by: Christian Ciach <[email protected]>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
@ChristianCiach @Hariharasuthan99
docs: Mention configmap to enable new git file globbing by name (argo…
d350a3a 
…proj#17936)

Signed-off-by: Christian Ciach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChristianCiach @crenshaw-dev