Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): improve the msg to user when deleteing the resource #17734

Merged
merged 1 commit into from
Apr 4, 2024
Merged

chore(ui): improve the msg to user when deleteing the resource #17734

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ui/src/app/applications/components/utils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,9 @@ export async function deleteApplication(appName: string, appNamespace: string, a
<div>
<p>
Are you sure you want to delete the application <kbd>{appName}</kbd>?
<span style={{display: 'block', marginBottom: '10px'}} />
Deleting the application in <kbd>foreground</kbd> or <kbd>background</kbd> mode will delete all the application's managed resources, which can be{' '}
<strong>dangerous</strong>. Be sure you understand the effects of deleting this resource before continuing. Consider asking someone to review the change first.
</p>
<div className='argo-form-row'>
<FormField
Expand Down Expand Up @@ -300,6 +303,9 @@ export const deletePodAction = async (pod: appModels.Pod, appContext: AppContext
<div>
<p>
Are you sure you want to delete Pod <kbd>{pod.name}</kbd>?
<span style={{display: 'block', marginBottom: '10px'}} />
Deleting resources can be <strong>dangerous</strong>. Be sure you understand the effects of deleting this resource before continuing. Consider asking someone to
review the change first.
</p>
<div className='argo-form-row' style={{paddingLeft: '30px'}}>
<CheckboxField id='force-delete-checkbox' field='force'>
Expand Down Expand Up @@ -343,7 +349,11 @@ export const deletePopup = async (ctx: ContextApis, resource: ResourceTreeNode,
<div>
<p>
Are you sure you want to delete {resource.kind} <kbd>{resource.name}</kbd>?
<span style={{display: 'block', marginBottom: '10px'}} />
Deleting resources can be <strong>dangerous</strong>. Be sure you understand the effects of deleting this resource before continuing. Consider asking someone to
review the change first.
</p>

{isManaged ? (
<div className='argo-form-row'>
<FormField label={`Please type '${resource.name}' to confirm the deletion of the resource`} formApi={api} field='resourceName' component={Text} />
Expand Down
Loading