Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify multiple sources example #17698

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

kostis-codefresh
Copy link
Member

Make it clear that multiple sources is not a way to group unrelated application. The current example unfortunately does show exactly that (grouping guestbook and elastic)

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: Kostis (Codefresh) <[email protected]>
Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@edlee2121 edlee2121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@leoluz leoluz merged commit 405949b into argoproj:master Apr 2, 2024
23 checks passed
BKirov pushed a commit to BKirov/argo-cd that referenced this pull request Apr 3, 2024
Signed-off-by: Kostis (Codefresh) <[email protected]>
Signed-off-by: Boyan Kirov <[email protected]>
BKirov pushed a commit to BKirov/argo-cd that referenced this pull request Apr 4, 2024
Signed-off-by: Kostis (Codefresh) <[email protected]>
Signed-off-by: Boyan Kirov <[email protected]>
mkieweg pushed a commit to mkieweg/argo-cd that referenced this pull request Jun 11, 2024
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants