fix: infer correct shard in statefulset setup (#17124, #17016) (#17167) #17204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: infer correct shard in statefulset setup Signed-off-by: Lukas Wöhrl <[email protected]> * fix the case if only a single replica Signed-off-by: Lukas Wöhrl <[email protected]> * fix: resolving pointer on shard compare Signed-off-by: Lukas Wöhrl <[email protected]> * fix: add readlock for cluster accessor Signed-off-by: Lukas Wöhrl <[email protected]> * fix: use defer to protect access of 'shard' Signed-off-by: Lukas Wöhrl <[email protected]> * fix: revert locking in getclusteraccessor Signed-off-by: Lukas Wöhrl <[email protected]> * fix: handle nil shard case Signed-off-by: Lukas Wöhrl <[email protected]> * fix: handle any nil shard value as false Signed-off-by: Lukas Wöhrl <[email protected]> * fix: handle nil case and fix another missing pointer dereference Signed-off-by: Lukas Wöhrl <[email protected]> * revert Signed-off-by: Lukas Wöhrl <[email protected]> * fix: added tests and fixed some behaviour bugs Signed-off-by: Lukas Wöhrl <[email protected]> * test: add test to validate that Shard value is not overriden Signed-off-by: Lukas Wöhrl <[email protected]> * fix: added tests and fixe the case when server is changed inside a secret Signed-off-by: Lukas Wöhrl <[email protected]> * tests: add test cases for infering the shard logic Signed-off-by: Lukas Wöhrl <[email protected]> --------- Signed-off-by: Lukas Wöhrl <[email protected]> (cherry picked from commit 5d6111b)
Signed-off-by: ishitasequeira <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release-2.10 #17204 +/- ##
================================================
+ Coverage 49.41% 49.72% +0.31%
================================================
Files 272 272
Lines 47897 47964 +67
================================================
+ Hits 23666 23850 +184
+ Misses 21896 21765 -131
- Partials 2335 2349 +14 ☔ View full report in Codecov by Sentry. |
crenshaw-dev
approved these changes
Feb 13, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherrypick fix: infer correct shard in statefulset setup (#17124, #17016) (#17167)