Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: otel grpc dependency deprecated issue #17103

Closed
wants to merge 6 commits into from
Closed

fix: otel grpc dependency deprecated issue #17103

wants to merge 6 commits into from

Conversation

gdsoumya
Copy link
Member

@gdsoumya gdsoumya commented Feb 6, 2024 •
edited
Loading

Fixes lint issue with deprecated warnings for otel grpc middleware.

Ref: Official updated examples (server, client)

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@gdsoumya
fix: otel grpc dependency deprecated issue
8cbbe6f 
Signed-off-by: Soumya Ghosh Dastidar <[email protected]>
@gdsoumya gdsoumya requested a review from a team as a code owner February 6, 2024 19:54
@gdsoumya gdsoumya mentioned this pull request Feb 6, 2024
Closed
14 tasks
@blakepettersson blakepettersson enabled auto-merge (squash) February 6, 2024 20:18
@gdsoumya
Copy link
Member Author

gdsoumya commented Feb 6, 2024 •
edited
Loading

@blakepettersson we are hitting the CI ordering issue causing some required steps to skip, are you okay to push your CI fix to this PR and merge both fixes together?

@blakepettersson
chore(ci): set needs on jobs
4b67195 
Related to argoproj#16982. In order for the steps to properly run, we need to
set `needs: changes` on them.

Signed-off-by: Blake Pettersson <[email protected]>
@gdsoumya gdsoumya requested a review from a team as a code owner February 6, 2024 20:29
@gdsoumya gdsoumya mentioned this pull request Feb 6, 2024
Merged
14 tasks
@gdsoumya gdsoumya requested a review from a team as a code owner February 6, 2024 21:20
@gdsoumya gdsoumya closed this Feb 6, 2024
auto-merge was automatically disabled February 6, 2024 22:50

Pull request was closed

@blakepettersson blakepettersson mentioned this pull request Feb 13, 2024
Closed
14 tasks
@yitzhtal
Copy link
Contributor

Any updates on this? @gdsoumya

@gdsoumya
Copy link
Member Author

@talitz I see you raised the PR for updating the pkg but the lint checks are still failing. If you can fix it I'd be happy to review and merge it.

@blakepettersson blakepettersson mentioned this pull request Apr 9, 2024
Closed
14 tasks
This was referenced May 29, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@todaywasawesome todaywasawesome todaywasawesome approved these changes

@blakepettersson blakepettersson blakepettersson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gdsoumya @yitzhtal @blakepettersson @todaywasawesome