Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(grpcproxy): add missing GRPCKeepAliveEnforcementMinimum (cherry-pick #15708) #16576

Merged
merged 1 commit into from
Dec 8, 2023
Merged

fix(grpcproxy): add missing GRPCKeepAliveEnforcementMinimum (cherry-pick #15708) #16576

merged 1 commit into from
Dec 8, 2023

Conversation

maxbrunet
Copy link
Contributor

Cherry-picked fix(grpcproxy): add missing GRPCKeepAliveEnforcementMinimum (#15708)

the absence of the setting potentially causes ENHANCE_YOUR_CALM

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@phanama @todaywasawesome @maxbrunet
fix(grpcproxy): add missing GRPCKeepAliveEnforcementMinimum (argoproj…
2b722b7 
…#15708)

the absence of the setting potentially causes ENHANCE_YOUR_CALM

Signed-off-by: phanama <[email protected]>
Co-authored-by: Dan Garfield <[email protected]>
Signed-off-by: Maxime Brunet <[email protected]>
@maxbrunet maxbrunet requested a review from a team as a code owner December 7, 2023 23:05
@codecov Codecov
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (0e65b84) 50.04% compared to head (2b722b7) 50.03%.

Files Patch % Lines
pkg/apiclient/grpcproxy.go 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##           release-2.9   #16576      +/-   ##
===============================================
- Coverage        50.04%   50.03%   -0.02%     
===============================================
  Files              267      267              
  Lines            46204    46209       +5     
===============================================
- Hits             23122    23119       -3     
- Misses           20816    20823       +7     
- Partials          2266     2267       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ishitasequeira ishitasequeira merged commit ab3b2e7 into argoproj:release-2.9 Dec 8, 2023
19 of 20 checks passed
@maxbrunet maxbrunet deleted the cherry-pick-f7788a-release-2.9 branch December 8, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishitasequeira ishitasequeira ishitasequeira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxbrunet @ishitasequeira @phanama