chore: update PR template to suggest cherry-pick releases #16560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jesse Suen <[email protected]>
|
@ericblackburn - this is what I proposed in today's meeting |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #16560 +/- ##
=======================================
Coverage 49.48% 49.49%
=======================================
Files 270 270
Lines 47489 47489
=======================================
+ Hits 23502 23506 +4
+ Misses 21675 21672 -3
+ Partials 2312 2311 -1 ☔ View full report in Codecov by Sentry. |
vladfr
pushed a commit
to vladfr/argo-cd
that referenced
this pull request
Dec 13, 2023
…6560) Signed-off-by: Jesse Suen <[email protected]>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
…6560) Signed-off-by: Jesse Suen <[email protected]>
JulienFuix
pushed a commit
to JulienFuix/argo-cd
that referenced
this pull request
Feb 6, 2024
…6560) Signed-off-by: Jesse Suen <[email protected]>
lyda
pushed a commit
to lyda/argo-cd
that referenced
this pull request
Mar 28, 2024
…6560) Signed-off-by: Jesse Suen <[email protected]> Signed-off-by: Kevin Lyda <[email protected]>
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
…6560) Signed-off-by: Jesse Suen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In today's community meeting, I proposed that the authors of PRs could suggest how far back a bug fix should be cherry-picked. This adds an item as part of the checklist.
This allows the author to advocate for a cherry-pick, since they are fixing the bug for a reason (it probably impacts them). The fix may or may not be backported depending on the risk/complexity of the fix, as well as the age of the release, as decided by maintainers.
I also rearranged the checklist to have optional stuff at the bottom.
Checklist: