docs: fix format issue in rbac.md #16521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrongly placed horizontal line (`----`) was formatting code-block as a header. Fixed it with a necessary line break Signed-off-by: Elouan Keryell-Even <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #16521 +/- ##
=======================================
Coverage 49.49% 49.49%
=======================================
Files 270 270
Lines 47485 47485
=======================================
+ Hits 23501 23502 +1
+ Misses 21673 21672 -1
Partials 2311 2311 ☔ View full report in Codecov by Sentry. |
blakepettersson
changed the title
There was a problem hiding this comment.
@elouanKeryell-Even , can you attach the screenshot of what the documentation looks like post your change?
crenshaw-dev
approved these changes
Dec 5, 2023
|
/cherry-pick release-2.9 |
|
/cherry-pick release-2.8 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
Wrongly placed horizontal line (`----`) was formatting code-block as a header. Fixed it with a necessary line break Signed-off-by: Elouan Keryell-Even <[email protected]>
|
/cherry-pick release-2.7 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
Wrongly placed horizontal line (`----`) was formatting code-block as a header. Fixed it with a necessary line break Signed-off-by: Elouan Keryell-Even <[email protected]>
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
Wrongly placed horizontal line (`----`) was formatting code-block as a header. Fixed it with a necessary line break Signed-off-by: Elouan Keryell-Even <[email protected]>
crenshaw-dev
pushed a commit
that referenced
this pull request
Dec 6, 2023
Wrongly placed horizontal line (`----`) was formatting code-block as a header. Fixed it with a necessary line break Signed-off-by: Elouan Keryell-Even <[email protected]> Co-authored-by: Elouan Keryell-Even <[email protected]>
crenshaw-dev
pushed a commit
that referenced
this pull request
Dec 6, 2023
Wrongly placed horizontal line (`----`) was formatting code-block as a header. Fixed it with a necessary line break Signed-off-by: Elouan Keryell-Even <[email protected]> Co-authored-by: Elouan Keryell-Even <[email protected]>
crenshaw-dev
pushed a commit
that referenced
this pull request
Dec 6, 2023
Wrongly placed horizontal line (`----`) was formatting code-block as a header. Fixed it with a necessary line break Signed-off-by: Elouan Keryell-Even <[email protected]> Co-authored-by: Elouan Keryell-Even <[email protected]>
vladfr
pushed a commit
to vladfr/argo-cd
that referenced
this pull request
Dec 13, 2023
Wrongly placed horizontal line (`----`) was formatting code-block as a header. Fixed it with a necessary line break Signed-off-by: Elouan Keryell-Even <[email protected]>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
Wrongly placed horizontal line (`----`) was formatting code-block as a header. Fixed it with a necessary line break Signed-off-by: Elouan Keryell-Even <[email protected]>
JulienFuix
pushed a commit
to JulienFuix/argo-cd
that referenced
this pull request
Feb 6, 2024
Wrongly placed horizontal line (`----`) was formatting code-block as a header. Fixed it with a necessary line break Signed-off-by: Elouan Keryell-Even <[email protected]>
lyda
pushed a commit
to lyda/argo-cd
that referenced
this pull request
Mar 28, 2024
Wrongly placed horizontal line (`----`) was formatting code-block as a header. Fixed it with a necessary line break Signed-off-by: Elouan Keryell-Even <[email protected]> Signed-off-by: Kevin Lyda <[email protected]>
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
Wrongly placed horizontal line (`----`) was formatting code-block as a header. Fixed it with a necessary line break Signed-off-by: Elouan Keryell-Even <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is a code block which is formatted as a header
Hoping to fix it with a line break between the code-block and the following horizontal rule (
---)original formatting issue (you can see code block being treated as header):
Checklist: