-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Argocd notification self service #16488
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
…_self_service3 # Conflicts: # go.mod # go.sum # notification_controller/controller/controller.go
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
…self-service Signed-off-by: May Zhang <[email protected]>
… into may_notifications_self_service3 # Conflicts: # docs/operator-manual/notifications/index.md # notification_controller/controller/controller.go
Signed-off-by: May Zhang <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #16488 +/- ##
==========================================
- Coverage 49.53% 49.50% -0.03%
==========================================
Files 269 269
Lines 47321 47430 +109
==========================================
+ Hits 23441 23482 +41
- Misses 21576 21643 +67
- Partials 2304 2305 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
crenshaw-dev
approved these changes
Nov 30, 2023
13 tasks
vladfr
pushed a commit
to vladfr/argo-cd
that referenced
this pull request
Dec 13, 2023
* self service notification Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * update notification engine Signed-off-by: May Zhang <[email protected]> * re-trigger build Signed-off-by: May Zhang <[email protected]> * self service notification Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * update notification engine Signed-off-by: May Zhang <[email protected]> * re-trigger build Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * update notification enginer version Signed-off-by: May Zhang <[email protected]> * update notification enginer version Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * add back checkAppNotInAdditionalNamespaces Signed-off-by: May Zhang <[email protected]> * add cm and secret to clusterRole Signed-off-by: May Zhang <[email protected]> * if applicationNamespaces is not used, then use namespaced appClient Signed-off-by: May Zhang <[email protected]> * fix merge conflict Signed-off-by: May Zhang <[email protected]> * fix doc and test based on review Signed-off-by: May Zhang <[email protected]> * self service notification Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * update notification engine Signed-off-by: May Zhang <[email protected]> * re-trigger build Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * self service notification Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * update notification engine Signed-off-by: May Zhang <[email protected]> * re-trigger build Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * update notification enginer version Signed-off-by: May Zhang <[email protected]> * update notification enginer version Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * add back checkAppNotInAdditionalNamespaces Signed-off-by: May Zhang <[email protected]> * add cm and secret to clusterRole Signed-off-by: May Zhang <[email protected]> * if applicationNamespaces is not used, then use namespaced appClient Signed-off-by: May Zhang <[email protected]> * fix doc and test based on review Signed-off-by: May Zhang <[email protected]> * disable defining and using secrets within notification templates for self-service Signed-off-by: May Zhang <[email protected]> * tweaks Signed-off-by: Michael Crenshaw <[email protected]> * fix docs formatting Signed-off-by: Michael Crenshaw <[email protected]> * more docs and Procfile update for local run convenience Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: May Zhang <[email protected]> Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
* self service notification Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * update notification engine Signed-off-by: May Zhang <[email protected]> * re-trigger build Signed-off-by: May Zhang <[email protected]> * self service notification Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * update notification engine Signed-off-by: May Zhang <[email protected]> * re-trigger build Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * update notification enginer version Signed-off-by: May Zhang <[email protected]> * update notification enginer version Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * add back checkAppNotInAdditionalNamespaces Signed-off-by: May Zhang <[email protected]> * add cm and secret to clusterRole Signed-off-by: May Zhang <[email protected]> * if applicationNamespaces is not used, then use namespaced appClient Signed-off-by: May Zhang <[email protected]> * fix merge conflict Signed-off-by: May Zhang <[email protected]> * fix doc and test based on review Signed-off-by: May Zhang <[email protected]> * self service notification Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * update notification engine Signed-off-by: May Zhang <[email protected]> * re-trigger build Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * self service notification Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * update notification engine Signed-off-by: May Zhang <[email protected]> * re-trigger build Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * update notification enginer version Signed-off-by: May Zhang <[email protected]> * update notification enginer version Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * add back checkAppNotInAdditionalNamespaces Signed-off-by: May Zhang <[email protected]> * add cm and secret to clusterRole Signed-off-by: May Zhang <[email protected]> * if applicationNamespaces is not used, then use namespaced appClient Signed-off-by: May Zhang <[email protected]> * fix doc and test based on review Signed-off-by: May Zhang <[email protected]> * disable defining and using secrets within notification templates for self-service Signed-off-by: May Zhang <[email protected]> * tweaks Signed-off-by: Michael Crenshaw <[email protected]> * fix docs formatting Signed-off-by: Michael Crenshaw <[email protected]> * more docs and Procfile update for local run convenience Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: May Zhang <[email protected]> Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>
JulienFuix
pushed a commit
to JulienFuix/argo-cd
that referenced
this pull request
Feb 6, 2024
* self service notification Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * update notification engine Signed-off-by: May Zhang <[email protected]> * re-trigger build Signed-off-by: May Zhang <[email protected]> * self service notification Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * update notification engine Signed-off-by: May Zhang <[email protected]> * re-trigger build Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * update notification enginer version Signed-off-by: May Zhang <[email protected]> * update notification enginer version Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * add back checkAppNotInAdditionalNamespaces Signed-off-by: May Zhang <[email protected]> * add cm and secret to clusterRole Signed-off-by: May Zhang <[email protected]> * if applicationNamespaces is not used, then use namespaced appClient Signed-off-by: May Zhang <[email protected]> * fix merge conflict Signed-off-by: May Zhang <[email protected]> * fix doc and test based on review Signed-off-by: May Zhang <[email protected]> * self service notification Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * update notification engine Signed-off-by: May Zhang <[email protected]> * re-trigger build Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * self service notification Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * update notification engine Signed-off-by: May Zhang <[email protected]> * re-trigger build Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * update notification enginer version Signed-off-by: May Zhang <[email protected]> * update notification enginer version Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * add back checkAppNotInAdditionalNamespaces Signed-off-by: May Zhang <[email protected]> * add cm and secret to clusterRole Signed-off-by: May Zhang <[email protected]> * if applicationNamespaces is not used, then use namespaced appClient Signed-off-by: May Zhang <[email protected]> * fix doc and test based on review Signed-off-by: May Zhang <[email protected]> * disable defining and using secrets within notification templates for self-service Signed-off-by: May Zhang <[email protected]> * tweaks Signed-off-by: Michael Crenshaw <[email protected]> * fix docs formatting Signed-off-by: Michael Crenshaw <[email protected]> * more docs and Procfile update for local run convenience Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: May Zhang <[email protected]> Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>
lyda
pushed a commit
to lyda/argo-cd
that referenced
this pull request
Mar 28, 2024
* self service notification Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * update notification engine Signed-off-by: May Zhang <[email protected]> * re-trigger build Signed-off-by: May Zhang <[email protected]> * self service notification Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * update notification engine Signed-off-by: May Zhang <[email protected]> * re-trigger build Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * update notification enginer version Signed-off-by: May Zhang <[email protected]> * update notification enginer version Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * add back checkAppNotInAdditionalNamespaces Signed-off-by: May Zhang <[email protected]> * add cm and secret to clusterRole Signed-off-by: May Zhang <[email protected]> * if applicationNamespaces is not used, then use namespaced appClient Signed-off-by: May Zhang <[email protected]> * fix merge conflict Signed-off-by: May Zhang <[email protected]> * fix doc and test based on review Signed-off-by: May Zhang <[email protected]> * self service notification Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * update notification engine Signed-off-by: May Zhang <[email protected]> * re-trigger build Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * self service notification Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * update notification engine Signed-off-by: May Zhang <[email protected]> * re-trigger build Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * update notification enginer version Signed-off-by: May Zhang <[email protected]> * update notification enginer version Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * add back checkAppNotInAdditionalNamespaces Signed-off-by: May Zhang <[email protected]> * add cm and secret to clusterRole Signed-off-by: May Zhang <[email protected]> * if applicationNamespaces is not used, then use namespaced appClient Signed-off-by: May Zhang <[email protected]> * fix doc and test based on review Signed-off-by: May Zhang <[email protected]> * disable defining and using secrets within notification templates for self-service Signed-off-by: May Zhang <[email protected]> * tweaks Signed-off-by: Michael Crenshaw <[email protected]> * fix docs formatting Signed-off-by: Michael Crenshaw <[email protected]> * more docs and Procfile update for local run convenience Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: May Zhang <[email protected]> Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]> Signed-off-by: Kevin Lyda <[email protected]>
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
* self service notification Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * update notification engine Signed-off-by: May Zhang <[email protected]> * re-trigger build Signed-off-by: May Zhang <[email protected]> * self service notification Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * update notification engine Signed-off-by: May Zhang <[email protected]> * re-trigger build Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * update notification enginer version Signed-off-by: May Zhang <[email protected]> * update notification enginer version Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * add back checkAppNotInAdditionalNamespaces Signed-off-by: May Zhang <[email protected]> * add cm and secret to clusterRole Signed-off-by: May Zhang <[email protected]> * if applicationNamespaces is not used, then use namespaced appClient Signed-off-by: May Zhang <[email protected]> * fix merge conflict Signed-off-by: May Zhang <[email protected]> * fix doc and test based on review Signed-off-by: May Zhang <[email protected]> * self service notification Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * update notification engine Signed-off-by: May Zhang <[email protected]> * re-trigger build Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * self service notification Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * revert back the changes for redis-ha Signed-off-by: May Zhang <[email protected]> * update notification engine Signed-off-by: May Zhang <[email protected]> * re-trigger build Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * fix conflict Signed-off-by: May Zhang <[email protected]> * update notification enginer version Signed-off-by: May Zhang <[email protected]> * update notification enginer version Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * fixing go tidy Signed-off-by: May Zhang <[email protected]> * add back checkAppNotInAdditionalNamespaces Signed-off-by: May Zhang <[email protected]> * add cm and secret to clusterRole Signed-off-by: May Zhang <[email protected]> * if applicationNamespaces is not used, then use namespaced appClient Signed-off-by: May Zhang <[email protected]> * fix doc and test based on review Signed-off-by: May Zhang <[email protected]> * disable defining and using secrets within notification templates for self-service Signed-off-by: May Zhang <[email protected]> * tweaks Signed-off-by: Michael Crenshaw <[email protected]> * fix docs formatting Signed-off-by: Michael Crenshaw <[email protected]> * more docs and Procfile update for local run convenience Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: May Zhang <[email protected]> Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: