Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Argocd notification self service #16488

Merged
merged 63 commits into from
Nov 30, 2023

Conversation

mayzhang2000
Copy link
Contributor

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
…_self_service3

# Conflicts:
#	go.mod
#	go.sum
#	notification_controller/controller/controller.go
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
… into may_notifications_self_service3

# Conflicts:
#	docs/operator-manual/notifications/index.md
#	notification_controller/controller/controller.go
@mayzhang2000 mayzhang2000 requested review from a team as code owners November 29, 2023 20:22
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (4875b02) 49.53% compared to head (4c910e6) 49.50%.
Report is 6 commits behind head on master.

Files Patch % Lines
util/notification/settings/settings.go 18.18% 17 Missing and 1 partial ⚠️
notification_controller/controller/controller.go 74.28% 8 Missing and 1 partial ⚠️
cmd/argocd/commands/admin/notifications.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #16488      +/-   ##
==========================================
- Coverage   49.53%   49.50%   -0.03%     
==========================================
  Files         269      269              
  Lines       47321    47430     +109     
==========================================
+ Hits        23441    23482      +41     
- Misses      21576    21643      +67     
- Partials     2304     2305       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
@crenshaw-dev crenshaw-dev enabled auto-merge (squash) November 30, 2023 20:46
@crenshaw-dev crenshaw-dev merged commit 19fa5b9 into argoproj:master Nov 30, 2023
25 checks passed
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
* self service notification

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* update notification engine

Signed-off-by: May Zhang <[email protected]>

* re-trigger build

Signed-off-by: May Zhang <[email protected]>

* self service notification

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* update notification engine

Signed-off-by: May Zhang <[email protected]>

* re-trigger build

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* update notification enginer version

Signed-off-by: May Zhang <[email protected]>

* update notification enginer version

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* add back checkAppNotInAdditionalNamespaces

Signed-off-by: May Zhang <[email protected]>

* add cm and secret to clusterRole

Signed-off-by: May Zhang <[email protected]>

* if applicationNamespaces is not used, then use namespaced appClient

Signed-off-by: May Zhang <[email protected]>

* fix merge conflict

Signed-off-by: May Zhang <[email protected]>

* fix doc and test based on review

Signed-off-by: May Zhang <[email protected]>

* self service notification

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* update notification engine

Signed-off-by: May Zhang <[email protected]>

* re-trigger build

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* self service notification

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* update notification engine

Signed-off-by: May Zhang <[email protected]>

* re-trigger build

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* update notification enginer version

Signed-off-by: May Zhang <[email protected]>

* update notification enginer version

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* add back checkAppNotInAdditionalNamespaces

Signed-off-by: May Zhang <[email protected]>

* add cm and secret to clusterRole

Signed-off-by: May Zhang <[email protected]>

* if applicationNamespaces is not used, then use namespaced appClient

Signed-off-by: May Zhang <[email protected]>

* fix doc and test based on review

Signed-off-by: May Zhang <[email protected]>

* disable defining and using secrets within notification templates for self-service

Signed-off-by: May Zhang <[email protected]>

* tweaks

Signed-off-by: Michael Crenshaw <[email protected]>

* fix docs formatting

Signed-off-by: Michael Crenshaw <[email protected]>

* more docs and Procfile update for local run convenience

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: May Zhang <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
* self service notification

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* update notification engine

Signed-off-by: May Zhang <[email protected]>

* re-trigger build

Signed-off-by: May Zhang <[email protected]>

* self service notification

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* update notification engine

Signed-off-by: May Zhang <[email protected]>

* re-trigger build

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* update notification enginer version

Signed-off-by: May Zhang <[email protected]>

* update notification enginer version

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* add back checkAppNotInAdditionalNamespaces

Signed-off-by: May Zhang <[email protected]>

* add cm and secret to clusterRole

Signed-off-by: May Zhang <[email protected]>

* if applicationNamespaces is not used, then use namespaced appClient

Signed-off-by: May Zhang <[email protected]>

* fix merge conflict

Signed-off-by: May Zhang <[email protected]>

* fix doc and test based on review

Signed-off-by: May Zhang <[email protected]>

* self service notification

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* update notification engine

Signed-off-by: May Zhang <[email protected]>

* re-trigger build

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* self service notification

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* update notification engine

Signed-off-by: May Zhang <[email protected]>

* re-trigger build

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* update notification enginer version

Signed-off-by: May Zhang <[email protected]>

* update notification enginer version

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* add back checkAppNotInAdditionalNamespaces

Signed-off-by: May Zhang <[email protected]>

* add cm and secret to clusterRole

Signed-off-by: May Zhang <[email protected]>

* if applicationNamespaces is not used, then use namespaced appClient

Signed-off-by: May Zhang <[email protected]>

* fix doc and test based on review

Signed-off-by: May Zhang <[email protected]>

* disable defining and using secrets within notification templates for self-service

Signed-off-by: May Zhang <[email protected]>

* tweaks

Signed-off-by: Michael Crenshaw <[email protected]>

* fix docs formatting

Signed-off-by: Michael Crenshaw <[email protected]>

* more docs and Procfile update for local run convenience

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: May Zhang <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
JulienFuix pushed a commit to JulienFuix/argo-cd that referenced this pull request Feb 6, 2024
* self service notification

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* update notification engine

Signed-off-by: May Zhang <[email protected]>

* re-trigger build

Signed-off-by: May Zhang <[email protected]>

* self service notification

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* update notification engine

Signed-off-by: May Zhang <[email protected]>

* re-trigger build

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* update notification enginer version

Signed-off-by: May Zhang <[email protected]>

* update notification enginer version

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* add back checkAppNotInAdditionalNamespaces

Signed-off-by: May Zhang <[email protected]>

* add cm and secret to clusterRole

Signed-off-by: May Zhang <[email protected]>

* if applicationNamespaces is not used, then use namespaced appClient

Signed-off-by: May Zhang <[email protected]>

* fix merge conflict

Signed-off-by: May Zhang <[email protected]>

* fix doc and test based on review

Signed-off-by: May Zhang <[email protected]>

* self service notification

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* update notification engine

Signed-off-by: May Zhang <[email protected]>

* re-trigger build

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* self service notification

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* update notification engine

Signed-off-by: May Zhang <[email protected]>

* re-trigger build

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* update notification enginer version

Signed-off-by: May Zhang <[email protected]>

* update notification enginer version

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* add back checkAppNotInAdditionalNamespaces

Signed-off-by: May Zhang <[email protected]>

* add cm and secret to clusterRole

Signed-off-by: May Zhang <[email protected]>

* if applicationNamespaces is not used, then use namespaced appClient

Signed-off-by: May Zhang <[email protected]>

* fix doc and test based on review

Signed-off-by: May Zhang <[email protected]>

* disable defining and using secrets within notification templates for self-service

Signed-off-by: May Zhang <[email protected]>

* tweaks

Signed-off-by: Michael Crenshaw <[email protected]>

* fix docs formatting

Signed-off-by: Michael Crenshaw <[email protected]>

* more docs and Procfile update for local run convenience

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: May Zhang <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
lyda pushed a commit to lyda/argo-cd that referenced this pull request Mar 28, 2024
* self service notification

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* update notification engine

Signed-off-by: May Zhang <[email protected]>

* re-trigger build

Signed-off-by: May Zhang <[email protected]>

* self service notification

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* update notification engine

Signed-off-by: May Zhang <[email protected]>

* re-trigger build

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* update notification enginer version

Signed-off-by: May Zhang <[email protected]>

* update notification enginer version

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* add back checkAppNotInAdditionalNamespaces

Signed-off-by: May Zhang <[email protected]>

* add cm and secret to clusterRole

Signed-off-by: May Zhang <[email protected]>

* if applicationNamespaces is not used, then use namespaced appClient

Signed-off-by: May Zhang <[email protected]>

* fix merge conflict

Signed-off-by: May Zhang <[email protected]>

* fix doc and test based on review

Signed-off-by: May Zhang <[email protected]>

* self service notification

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* update notification engine

Signed-off-by: May Zhang <[email protected]>

* re-trigger build

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* self service notification

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* update notification engine

Signed-off-by: May Zhang <[email protected]>

* re-trigger build

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* update notification enginer version

Signed-off-by: May Zhang <[email protected]>

* update notification enginer version

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* add back checkAppNotInAdditionalNamespaces

Signed-off-by: May Zhang <[email protected]>

* add cm and secret to clusterRole

Signed-off-by: May Zhang <[email protected]>

* if applicationNamespaces is not used, then use namespaced appClient

Signed-off-by: May Zhang <[email protected]>

* fix doc and test based on review

Signed-off-by: May Zhang <[email protected]>

* disable defining and using secrets within notification templates for self-service

Signed-off-by: May Zhang <[email protected]>

* tweaks

Signed-off-by: Michael Crenshaw <[email protected]>

* fix docs formatting

Signed-off-by: Michael Crenshaw <[email protected]>

* more docs and Procfile update for local run convenience

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: May Zhang <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Kevin Lyda <[email protected]>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
* self service notification

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* update notification engine

Signed-off-by: May Zhang <[email protected]>

* re-trigger build

Signed-off-by: May Zhang <[email protected]>

* self service notification

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* update notification engine

Signed-off-by: May Zhang <[email protected]>

* re-trigger build

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* update notification enginer version

Signed-off-by: May Zhang <[email protected]>

* update notification enginer version

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* add back checkAppNotInAdditionalNamespaces

Signed-off-by: May Zhang <[email protected]>

* add cm and secret to clusterRole

Signed-off-by: May Zhang <[email protected]>

* if applicationNamespaces is not used, then use namespaced appClient

Signed-off-by: May Zhang <[email protected]>

* fix merge conflict

Signed-off-by: May Zhang <[email protected]>

* fix doc and test based on review

Signed-off-by: May Zhang <[email protected]>

* self service notification

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* update notification engine

Signed-off-by: May Zhang <[email protected]>

* re-trigger build

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* self service notification

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* update notification engine

Signed-off-by: May Zhang <[email protected]>

* re-trigger build

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* update notification enginer version

Signed-off-by: May Zhang <[email protected]>

* update notification enginer version

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* add back checkAppNotInAdditionalNamespaces

Signed-off-by: May Zhang <[email protected]>

* add cm and secret to clusterRole

Signed-off-by: May Zhang <[email protected]>

* if applicationNamespaces is not used, then use namespaced appClient

Signed-off-by: May Zhang <[email protected]>

* fix doc and test based on review

Signed-off-by: May Zhang <[email protected]>

* disable defining and using secrets within notification templates for self-service

Signed-off-by: May Zhang <[email protected]>

* tweaks

Signed-off-by: Michael Crenshaw <[email protected]>

* fix docs formatting

Signed-off-by: Michael Crenshaw <[email protected]>

* more docs and Procfile update for local run convenience

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: May Zhang <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants