Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(notifications): reduce confusion #16440

Closed
wants to merge 1 commit into from

Conversation

ManfredLiuSolera
Copy link

I'd suggest to use the same configmap and secrets name in the yaml example. and the channel name is variable.

Signed-off-by: Manfred Liu <[email protected]>
@ManfredLiuSolera ManfredLiuSolera requested review from a team as code owners November 24, 2023 07:11
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.53%. Comparing base (1600c03) to head (27eafd7).
Report is 1518 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #16440   +/-   ##
=======================================
  Coverage   49.53%   49.53%           
=======================================
  Files         269      269           
  Lines       47222    47222           
=======================================
  Hits        23392    23392           
  Misses      21530    21530           
  Partials     2300     2300           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blakepettersson blakepettersson changed the title reduce confusion docs: reduce confusion Jan 7, 2024
@blakepettersson blakepettersson changed the title docs: reduce confusion docs(notifications): reduce confusion Jan 7, 2024
@blakepettersson
Copy link
Member

I think the docs change actually needs to be done in notifications-engine first 😢

see https://github.com/argoproj/notifications-engine/blob/84b9f79136041bf0d6854c151b5bbad031c4b053/docs/services/teams.md

@pasha-codefresh
Copy link
Member

pasha-codefresh commented Feb 12, 2024

@ManfredLiuSolera could you please open PR with this change inside notification-engine ?

@blakepettersson blakepettersson marked this pull request as draft May 8, 2024 18:47
@blakepettersson
Copy link
Member

Marking as draft for now until a corresponding PR has been opened in notifications-engine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants