Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump otel to 1.21.0. #16420

Merged
merged 1 commit into from
Nov 22, 2023
Merged

chore: Bump otel to 1.21.0. #16420

merged 1 commit into from
Nov 22, 2023

Conversation

dlorenc
Copy link
Contributor

@dlorenc dlorenc commented Nov 22, 2023 •
edited
Loading

This actually wasn't that bad. It was just a few bumps in the right order.

I ran tests and built everything and it appears to work.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@dlorenc
Bump otel to 1.21.0.
c8fc470 
This actually wasn't that bad. It was just a few bumps in the right order.

I ran tests and built everything and it appears to work.

Signed-off-by: Dan Lorenc <[email protected]>
@dlorenc dlorenc requested a review from a team as a code owner November 22, 2023 02:20
@dlorenc
Copy link
Contributor Author

dlorenc commented Nov 22, 2023

I think this obsoletes #16368 #16028 #15721 and #15547

@codecov Codecov
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cbe6e2b) 49.54% compared to head (c8fc470) 49.54%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #16420   +/-   ##
=======================================
  Coverage   49.54%   49.54%           
=======================================
  Files         269      269           
  Lines       47222    47222           
=======================================
  Hits        23395    23395           
  Misses      21528    21528           
  Partials     2299     2299

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

crenshaw-dev
crenshaw-dev reviewed Nov 22, 2023
View reviewed changes
go.mod Show resolved Hide resolved
@crenshaw-dev crenshaw-dev merged commit 78460c4 into argoproj:master Nov 22, 2023
26 checks passed
alexymantha pushed a commit to alexymantha/argo-cd that referenced this pull request Nov 22, 2023
@dlorenc @alexymantha
chore: Bump otel to 1.21.0 (argoproj#16420)
0782f35 
This actually wasn't that bad. It was just a few bumps in the right order.

I ran tests and built everything and it appears to work.

Signed-off-by: Dan Lorenc <[email protected]>
filiprafaj pushed a commit to filiprafaj/argo-cd that referenced this pull request Nov 23, 2023
@dlorenc @filiprafaj
chore: Bump otel to 1.21.0 (argoproj#16420)
cc59e9b 
This actually wasn't that bad. It was just a few bumps in the right order.

I ran tests and built everything and it appears to work.

Signed-off-by: Dan Lorenc <[email protected]>
Signed-off-by: Filip Rafaj <[email protected]>
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
@dlorenc @vladfr
chore: Bump otel to 1.21.0 (argoproj#16420)
1d46eef 
This actually wasn't that bad. It was just a few bumps in the right order.

I ran tests and built everything and it appears to work.

Signed-off-by: Dan Lorenc <[email protected]>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
@dlorenc @tesla59
chore: Bump otel to 1.21.0 (argoproj#16420)
1243ef3 
This actually wasn't that bad. It was just a few bumps in the right order.

I ran tests and built everything and it appears to work.

Signed-off-by: Dan Lorenc <[email protected]>
@blakepettersson blakepettersson mentioned this pull request Jan 18, 2024
Closed
lyda pushed a commit to lyda/argo-cd that referenced this pull request Mar 28, 2024
@dlorenc @lyda
chore: Bump otel to 1.21.0 (argoproj#16420)
411617f 
This actually wasn't that bad. It was just a few bumps in the right order.

I ran tests and built everything and it appears to work.

Signed-off-by: Dan Lorenc <[email protected]>
Signed-off-by: Kevin Lyda <[email protected]>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
@dlorenc @Hariharasuthan99
chore: Bump otel to 1.21.0 (argoproj#16420)
20bc45a 
This actually wasn't that bad. It was just a few bumps in the right order.

I ran tests and built everything and it appears to work.

Signed-off-by: Dan Lorenc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dlorenc @crenshaw-dev