Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Use safe example domains defined in RFC 2606 #16389

Merged
merged 1 commit into from
Nov 20, 2023
Merged

chore: Use safe example domains defined in RFC 2606 #16389

merged 1 commit into from
Nov 20, 2023

Conversation

mkilchhofer
Copy link
Member

@mkilchhofer mkilchhofer commented Nov 19, 2023 •
edited
Loading

I observed that we use different example placeholders for URLs. IANA (Internet Assigned Numbers Authority) defines a reserved domain for example/documentation use. (see RFC 2606 and https://example.com/)
We should protect our users and/or contributors from using other domains and thus contacting arbitrary endpoints in the internet we do not control.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@codecov Codecov
Copy link

codecov bot commented Nov 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6fa9b17) 49.55% compared to head (dbbb7f5) 49.55%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #16389   +/-   ##
=======================================
  Coverage   49.55%   49.55%           
=======================================
  Files         269      269           
  Lines       47039    47039           
=======================================
+ Hits        23309    23310    +1     
+ Misses      21444    21443    -1     
  Partials     2286     2286

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkilchhofer mkilchhofer marked this pull request as ready for review November 19, 2023 22:57
@mkilchhofer mkilchhofer requested review from a team as code owners November 19, 2023 22:57
blakepettersson
blakepettersson approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@blakepettersson blakepettersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gdsoumya gdsoumya requested a review from a team November 20, 2023 08:53
gdsoumya
gdsoumya approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@gdsoumya gdsoumya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ishitasequeira ishitasequeira merged commit 841339d into argoproj:master Nov 20, 2023
36 checks passed
@mkilchhofer mkilchhofer deleted the bugfix/use_safe_example_domains branch November 20, 2023 18:06
alexymantha pushed a commit to alexymantha/argo-cd that referenced this pull request Nov 22, 2023
@mkilchhofer @alexymantha
chore: Use safe example domains defined in RFC 2606 (argoproj#16389)
7965bad
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
@mkilchhofer @vladfr
chore: Use safe example domains defined in RFC 2606 (argoproj#16389)
033ac75
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
@mkilchhofer @tesla59
chore: Use safe example domains defined in RFC 2606 (argoproj#16389)
8daf8dd
lyda pushed a commit to lyda/argo-cd that referenced this pull request Mar 28, 2024
@mkilchhofer @lyda
chore: Use safe example domains defined in RFC 2606 (argoproj#16389)
1ab1571 
Signed-off-by: Kevin Lyda <[email protected]>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
@mkilchhofer @Hariharasuthan99
chore: Use safe example domains defined in RFC 2606 (argoproj#16389)
cc7c9da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishitasequeira ishitasequeira ishitasequeira approved these changes

@gdsoumya gdsoumya gdsoumya approved these changes

@blakepettersson blakepettersson blakepettersson approved these changes

@jmeridth jmeridth jmeridth approved these changes

Assignees
No one assigned
Labels
ready-for-review
Projects
Argo CD Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mkilchhofer @jmeridth @blakepettersson @gdsoumya @ishitasequeira