Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add atlas operator resources #16357 #16364

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

rotemtam
Copy link
Contributor

@rotemtam rotemtam commented Nov 16, 2023

Closes #16357

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@rotemtam rotemtam requested a review from a team as a code owner November 16, 2023 17:17
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (19fa5b9) 49.50% compared to head (12a8d40) 49.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #16364   +/-   ##
=======================================
  Coverage   49.50%   49.50%           
=======================================
  Files         269      269           
  Lines       47430    47430           
=======================================
  Hits        23479    23479           
  Misses      21645    21645           
  Partials     2306     2306           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rotemtam rotemtam force-pushed the feat/atlasgo-resources branch 3 times, most recently from 6c60982 to 12ed98a Compare November 17, 2023 17:35
@rotemtam rotemtam force-pushed the feat/atlasgo-resources branch from 12ed98a to ac294db Compare November 18, 2023 15:39
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Awesome first contribution!

@todaywasawesome todaywasawesome enabled auto-merge (squash) November 18, 2023 15:45
Copy link
Member

@pasha-codefresh pasha-codefresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@todaywasawesome todaywasawesome merged commit 35f1ee7 into argoproj:master Dec 7, 2023
25 checks passed
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
JulienFuix pushed a commit to JulienFuix/argo-cd that referenced this pull request Feb 6, 2024
lyda pushed a commit to lyda/argo-cd that referenced this pull request Mar 28, 2024
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Atlas Operator CRs
4 participants