Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix kustomize patches example #16353

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Conversation

morey-tech
Copy link
Contributor

@morey-tech morey-tech commented Nov 15, 2023

Related to: #16352 Also, add an ApplicationSet example.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Related to: argoproj#16352 Also, add an ApplicationSet example. 

Signed-off-by: Nicholas Morey <[email protected]>
Signed-off-by: Nicholas Morey <[email protected]>
@morey-tech morey-tech marked this pull request as ready for review November 15, 2023 20:28
@morey-tech morey-tech requested review from a team as code owners November 15, 2023 20:28
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ae07eb6) 49.55% compared to head (4ebd64a) 49.55%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #16353   +/-   ##
=======================================
  Coverage   49.55%   49.55%           
=======================================
  Files         269      269           
  Lines       47039    47039           
=======================================
  Hits        23310    23310           
  Misses      21443    21443           
  Partials     2286     2286           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the example!

@alexmt alexmt merged commit 6ede1a8 into argoproj:master Nov 15, 2023
25 checks passed
GilUpstream pushed a commit to GilUpstream/argo-cd that referenced this pull request Nov 15, 2023
* docs: fix kustomize patches example

Related to: argoproj#16352 Also, add an ApplicationSet example.

Signed-off-by: Nicholas Morey <[email protected]>

* fix: spelling

Signed-off-by: Nicholas Morey <[email protected]>

---------

Signed-off-by: Nicholas Morey <[email protected]>
Signed-off-by: Gilad Salmon <[email protected]>
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
* docs: fix kustomize patches example

Related to: argoproj#16352 Also, add an ApplicationSet example. 

Signed-off-by: Nicholas Morey <[email protected]>

* fix: spelling

Signed-off-by: Nicholas Morey <[email protected]>

---------

Signed-off-by: Nicholas Morey <[email protected]>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
* docs: fix kustomize patches example

Related to: argoproj#16352 Also, add an ApplicationSet example. 

Signed-off-by: Nicholas Morey <[email protected]>

* fix: spelling

Signed-off-by: Nicholas Morey <[email protected]>

---------

Signed-off-by: Nicholas Morey <[email protected]>
lyda pushed a commit to lyda/argo-cd that referenced this pull request Mar 28, 2024
* docs: fix kustomize patches example

Related to: argoproj#16352 Also, add an ApplicationSet example.

Signed-off-by: Nicholas Morey <[email protected]>

* fix: spelling

Signed-off-by: Nicholas Morey <[email protected]>

---------

Signed-off-by: Nicholas Morey <[email protected]>
Signed-off-by: Kevin Lyda <[email protected]>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
* docs: fix kustomize patches example

Related to: argoproj#16352 Also, add an ApplicationSet example. 

Signed-off-by: Nicholas Morey <[email protected]>

* fix: spelling

Signed-off-by: Nicholas Morey <[email protected]>

---------

Signed-off-by: Nicholas Morey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants