Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Clarify that enterpriseBaseURL requires /api/v3 suffix #16347

Closed

Conversation

lindhe
Copy link
Contributor

@lindhe lindhe commented Nov 15, 2023

Relates to argoproj/notifications-engine#205

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@lindhe lindhe requested review from a team as code owners November 15, 2023 12:49
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.55%. Comparing base (6ede1a8) to head (72c640e).
Report is 1062 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #16347   +/-   ##
=======================================
  Coverage   49.55%   49.55%           
=======================================
  Files         269      269           
  Lines       47039    47039           
=======================================
  Hits        23310    23310           
  Misses      21443    21443           
  Partials     2286     2286           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pasha-codefresh
Copy link
Member

@lindhe you need to do these changes in notification-engine
https://github.com/argoproj/notifications-engine/blob/master/docs/services/github.md

And after just update notification-engine version inside argocd and run make codegen

@lindhe
Copy link
Contributor Author

lindhe commented May 10, 2024

Ah, I see. Thanks for the pointer!

I've created argoproj/notifications-engine#292 now, how do I proceed with the codegen? I assume the new PR must be merged first and then we update this PR with the codegen changes? Or what's the exact order of operations?

@lindhe lindhe deleted the lindhe/update-docs-notifications-github branch September 3, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants