fix: argocd notification controller app client permission issue (cherry-pick #16057) #16161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcp-cherry-pick-bot[bot]](https://avatars.githubusercontent.com/in/169664?s=60&v=4){kind=small}
) * if applicationNamespaces is not provided as input parameter, then use namespaced appClient Signed-off-by: May Zhang <[email protected]> * fix go lint error Signed-off-by: May Zhang <[email protected]> --------- Signed-off-by: May Zhang <[email protected]>
crenshaw-dev
approved these changes
Oct 30, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release-2.7 #16161 +/- ##
===============================================
- Coverage 48.90% 48.89% -0.01%
===============================================
Files 248 248
Lines 43116 43121 +5
===============================================
Hits 21086 21086
- Misses 19908 19913 +5
Partials 2122 2122
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked fix: argocd notification controller app cluster permission issue (#16057)
Signed-off-by: May Zhang [email protected]
Signed-off-by: May Zhang [email protected]
Signed-off-by: May Zhang [email protected]