Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): summary: fix sync options block layout #16152

Merged
merged 2 commits into from
Nov 3, 2023
Merged

fix(ui): summary: fix sync options block layout #16152

merged 2 commits into from
Nov 3, 2023

Conversation

ksrt12
Copy link
Contributor

@ksrt12 ksrt12 commented Oct 30, 2023 •
edited
Loading

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@ksrt12 ksrt12 requested a review from a team as a code owner October 30, 2023 12:35
@codecov
Copy link

codecov bot commented Oct 30, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (48f175b) 49.56% compared to head (7b07164) 49.56%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #16152      +/-   ##
==========================================
- Coverage   49.56%   49.56%   -0.01%     
==========================================
  Files         269      269              
  Lines       46827    46827              
==========================================
- Hits        23212    23211       -1     
- Misses      21339    21340       +1     
  Partials     2276     2276

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev
Copy link
Member

@ksrt12 can you write up a description of the problem and the solution, ideally w/ screenshots of both?

@ksrt12
Copy link
Contributor Author

ksrt12 commented Oct 30, 2023

@ksrt12 can you write up a description of the problem and the solution, ideally w/ screenshots of both?

sure, I just forgot

before
image

after
image

ishitasequeira
ishitasequeira approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ksrt12.
LGTM!

@ishitasequeira ishitasequeira merged commit 740df9a into argoproj:master Nov 3, 2023
23 checks passed
jmilic1 pushed a commit to jmilic1/argo-cd that referenced this pull request Nov 13, 2023
@ksrt12 @jmilic1
fix(ui): summary: fix sync options block layout (argoproj#16152)
f4ef431 
Signed-off-by: Kazakov Stepan <[email protected]>
Signed-off-by: jmilic1 <[email protected]>
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
@ksrt12 @vladfr
fix(ui): summary: fix sync options block layout (argoproj#16152)
bcd08e3 
Signed-off-by: Kazakov Stepan <[email protected]>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
@ksrt12 @tesla59
fix(ui): summary: fix sync options block layout (argoproj#16152)
38a8afe 
Signed-off-by: Kazakov Stepan <[email protected]>
@ksrt12 ksrt12 deleted the patch-1 branch January 9, 2024 23:54
lyda pushed a commit to lyda/argo-cd that referenced this pull request Mar 28, 2024
@ksrt12 @lyda
fix(ui): summary: fix sync options block layout (argoproj#16152)
65c3c62 
Signed-off-by: Kazakov Stepan <[email protected]>
Signed-off-by: Kevin Lyda <[email protected]>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
@ksrt12 @Hariharasuthan99
fix(ui): summary: fix sync options block layout (argoproj#16152)
d9dfc6b 
Signed-off-by: Kazakov Stepan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishitasequeira ishitasequeira ishitasequeira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ksrt12 @crenshaw-dev @ishitasequeira