fix: Remove unnecessary error checking #16150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #16150 +/- ##
==========================================
- Coverage 49.56% 49.55% -0.02%
==========================================
Files 269 269
Lines 46827 46891 +64
==========================================
+ Hits 23212 23235 +23
- Misses 21339 21375 +36
- Partials 2276 2281 +5 ☔ View full report in Codecov by Sentry. |
crenshaw-dev
changed the title
|
@navist2020 can you fix the DCO check? |
Signed-off-by: lijun <[email protected]>
navist2020
force-pushed
the
typo/rm_checkError
branch
from
ee05bc6 to
e5886d1
Compare
|
@crenshaw-dev Thanks for your response. |
ishitasequeira
approved these changes
Nov 1, 2023
jmilic1
pushed a commit
to jmilic1/argo-cd
that referenced
this pull request
Nov 13, 2023
Signed-off-by: lijun <[email protected]> Signed-off-by: jmilic1 <[email protected]>
vladfr
pushed a commit
to vladfr/argo-cd
that referenced
this pull request
Dec 13, 2023
Signed-off-by: lijun <[email protected]>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
Signed-off-by: lijun <[email protected]>
lyda
pushed a commit
to lyda/argo-cd
that referenced
this pull request
Mar 28, 2024
Signed-off-by: lijun <[email protected]> Signed-off-by: Kevin Lyda <[email protected]>
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
Signed-off-by: lijun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error checking seems unnecessary because the previous code did not return a new error.