-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): fix repo field name in GCP Cloud Source Repositories docs #16107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `url` Signed-off-by: Gestalt LUR <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #16107 +/- ##
=======================================
Coverage 49.54% 49.54%
=======================================
Files 269 269
Lines 46641 46641
=======================================
+ Hits 23109 23110 +1
+ Misses 21259 21258 -1
Partials 2273 2273 ☔ View full report in Codecov by Sentry. |
ishitasequeira
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nyanshell for the PR. LGTM!
/cherry-pick release-2.9 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Nov 2, 2023
… `url` (#16107) Signed-off-by: Gestalt LUR <[email protected]>
ishitasequeira
pushed a commit
that referenced
this pull request
Nov 2, 2023
… `url` (#16107) (#16211) Signed-off-by: Gestalt LUR <[email protected]> Co-authored-by: Gestalt LUR <[email protected]>
jmilic1
pushed a commit
to jmilic1/argo-cd
that referenced
this pull request
Nov 13, 2023
… `url` (argoproj#16107) Signed-off-by: Gestalt LUR <[email protected]> Signed-off-by: jmilic1 <[email protected]>
vladfr
pushed a commit
to vladfr/argo-cd
that referenced
this pull request
Dec 13, 2023
… `url` (argoproj#16107) Signed-off-by: Gestalt LUR <[email protected]>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
… `url` (argoproj#16107) Signed-off-by: Gestalt LUR <[email protected]>
lyda
pushed a commit
to lyda/argo-cd
that referenced
this pull request
Mar 28, 2024
… `url` (argoproj#16107) Signed-off-by: Gestalt LUR <[email protected]> Signed-off-by: Kevin Lyda <[email protected]>
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
… `url` (argoproj#16107) Signed-off-by: Gestalt LUR <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
repo field name in GCP Cloud Source Repositories docs should be
url
instead ofrepo
. Therepo
is not working anymore.Checklist: