Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): proj role list example #16074

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Conversation

crenshaw-dev
Copy link
Member

Reviewed too quickly and missed an error.

Signed-off-by: Michael Crenshaw <[email protected]>
@crenshaw-dev crenshaw-dev requested review from a team as code owners October 23, 2023 13:48
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (973565e) 49.55% compared to head (f3d3019) 49.53%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #16074      +/-   ##
==========================================
- Coverage   49.55%   49.53%   -0.02%     
==========================================
  Files         269      269              
  Lines       46595    46613      +18     
==========================================
  Hits        23091    23091              
- Misses      21232    21250      +18     
  Partials     2272     2272              
Files Coverage Δ
applicationset/utils/createOrUpdate.go 0.00% <0.00%> (ø)
cmd/argocd/commands/gpg.go 0.00% <0.00%> (ø)
cmd/argocd/commands/project_role.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@christianh814 christianh814 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ishitasequeira ishitasequeira merged commit 5d3bdb5 into argoproj:master Oct 24, 2023
22 checks passed
@crenshaw-dev crenshaw-dev deleted the cli-fix branch October 25, 2023 00:33
ymktmk pushed a commit to ymktmk/argo-cd that referenced this pull request Oct 29, 2023
jmilic1 pushed a commit to jmilic1/argo-cd that referenced this pull request Nov 13, 2023
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: jmilic1 <[email protected]>
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants