-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: unstable integration test #15976
Conversation
Signed-off-by: naruse666 <[email protected]>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15976 +/- ##
=======================================
Coverage 49.66% 49.67%
=======================================
Files 267 267
Lines 46383 46383
=======================================
+ Hits 23036 23039 +3
+ Misses 21086 21084 -2
+ Partials 2261 2260 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: naruse666 <[email protected]>
Signed-off-by: naruse666 <[email protected]>
Signed-off-by: naruse666 <[email protected]>
As far as I've seen it's stable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* wait more Signed-off-by: naruse666 <[email protected]> * fix: wait Signed-off-by: naruse666 <[email protected]> * rerun Signed-off-by: naruse666 <[email protected]> * rerun 2 Signed-off-by: naruse666 <[email protected]> --------- Signed-off-by: naruse666 <[email protected]>
* wait more Signed-off-by: naruse666 <[email protected]> * fix: wait Signed-off-by: naruse666 <[email protected]> * rerun Signed-off-by: naruse666 <[email protected]> * rerun 2 Signed-off-by: naruse666 <[email protected]> --------- Signed-off-by: naruse666 <[email protected]> Signed-off-by: jmilic1 <[email protected]>
* wait more Signed-off-by: naruse666 <[email protected]> * fix: wait Signed-off-by: naruse666 <[email protected]> * rerun Signed-off-by: naruse666 <[email protected]> * rerun 2 Signed-off-by: naruse666 <[email protected]> --------- Signed-off-by: naruse666 <[email protected]>
* wait more Signed-off-by: naruse666 <[email protected]> * fix: wait Signed-off-by: naruse666 <[email protected]> * rerun Signed-off-by: naruse666 <[email protected]> * rerun 2 Signed-off-by: naruse666 <[email protected]> --------- Signed-off-by: naruse666 <[email protected]>
* wait more Signed-off-by: naruse666 <[email protected]> * fix: wait Signed-off-by: naruse666 <[email protected]> * rerun Signed-off-by: naruse666 <[email protected]> * rerun 2 Signed-off-by: naruse666 <[email protected]> --------- Signed-off-by: naruse666 <[email protected]>
* wait more Signed-off-by: naruse666 <[email protected]> * fix: wait Signed-off-by: naruse666 <[email protected]> * rerun Signed-off-by: naruse666 <[email protected]> * rerun 2 Signed-off-by: naruse666 <[email protected]> --------- Signed-off-by: naruse666 <[email protected]>
Closes [ISSUE #15868]
Description
Integration tests are often failed with follows error.
It fails with the same error and the same test every time.
Test is here.
https://github.com/argoproj/argo-cd/blob/master/test/e2e/app_management_ns_test.go#L2437C14-L2437C14
I'm guessing
SetEnableManifestGeneration
isn't worked with some reason.may be too short with just wait time of the when() func.
I'd like to see behavior when wait more before change
ApplicationSourceTypeKustomize
.Checklist: