Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unstable integration test #15976

Merged
merged 4 commits into from
Oct 15, 2023

Conversation

naruse666
Copy link
Contributor

@naruse666 naruse666 commented Oct 14, 2023

Closes [ISSUE #15868]

Description

Integration tests are often failed with follows error.
It fails with the same error and the same test every time.

	Error:      	Not equal: 
       	            	expected: "Kustomize"
       	            	actual  : "Directory"        	            	
       	            	Diff:
       	            	--- Expected
       	            	+++ Actual
       	            	@@ -1,2 +1,2 @@
       	            	-(v1alpha1.ApplicationSourceType) (len=9) "Kustomize"
       	            	+(v1alpha1.ApplicationSourceType) (len=9) "Directory"        	            	 
    	Test:       	TestNamespacedDisableManifestGeneration

Test is here.
https://github.com/argoproj/argo-cd/blob/master/test/e2e/app_management_ns_test.go#L2437C14-L2437C14

I'm guessing SetEnableManifestGeneration isn't worked with some reason.
may be too short with just wait time of the when() func.
I'd like to see behavior when wait more before change ApplicationSourceTypeKustomize.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Signed-off-by: naruse666 <[email protected]>
@naruse666 naruse666 requested a review from a team as a code owner October 14, 2023 19:26
@naruse666 naruse666 marked this pull request as draft October 14, 2023 19:28
@naruse666 naruse666 changed the title wait more fix: unstable integration test Oct 14, 2023
@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (af17c8d) 49.66% compared to head (ff1e71b) 49.67%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #15976   +/-   ##
=======================================
  Coverage   49.66%   49.67%           
=======================================
  Files         267      267           
  Lines       46383    46383           
=======================================
+ Hits        23036    23039    +3     
+ Misses      21086    21084    -2     
+ Partials     2261     2260    -1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

naruse666 added 3 commits October 15, 2023 04:51
Signed-off-by: naruse666 <[email protected]>
Signed-off-by: naruse666 <[email protected]>
Signed-off-by: naruse666 <[email protected]>
@naruse666
Copy link
Contributor Author

As far as I've seen it's stable.
This changes can be that we aren't need rerun integration tests.

@naruse666 naruse666 marked this pull request as ready for review October 15, 2023 00:09
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@crenshaw-dev crenshaw-dev merged commit dbc48f3 into argoproj:master Oct 15, 2023
30 checks passed
ymktmk pushed a commit to ymktmk/argo-cd that referenced this pull request Oct 29, 2023
* wait more

Signed-off-by: naruse666 <[email protected]>

* fix: wait

Signed-off-by: naruse666 <[email protected]>

* rerun

Signed-off-by: naruse666 <[email protected]>

* rerun 2

Signed-off-by: naruse666 <[email protected]>

---------

Signed-off-by: naruse666 <[email protected]>
jmilic1 pushed a commit to jmilic1/argo-cd that referenced this pull request Nov 13, 2023
* wait more

Signed-off-by: naruse666 <[email protected]>

* fix: wait

Signed-off-by: naruse666 <[email protected]>

* rerun

Signed-off-by: naruse666 <[email protected]>

* rerun 2

Signed-off-by: naruse666 <[email protected]>

---------

Signed-off-by: naruse666 <[email protected]>
Signed-off-by: jmilic1 <[email protected]>
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
* wait more

Signed-off-by: naruse666 <[email protected]>

* fix: wait

Signed-off-by: naruse666 <[email protected]>

* rerun

Signed-off-by: naruse666 <[email protected]>

* rerun 2

Signed-off-by: naruse666 <[email protected]>

---------

Signed-off-by: naruse666 <[email protected]>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
* wait more

Signed-off-by: naruse666 <[email protected]>

* fix: wait

Signed-off-by: naruse666 <[email protected]>

* rerun

Signed-off-by: naruse666 <[email protected]>

* rerun 2

Signed-off-by: naruse666 <[email protected]>

---------

Signed-off-by: naruse666 <[email protected]>
lukaszgyg pushed a commit to lukaszgyg/argo-cd that referenced this pull request Jan 12, 2024
* wait more

Signed-off-by: naruse666 <[email protected]>

* fix: wait

Signed-off-by: naruse666 <[email protected]>

* rerun

Signed-off-by: naruse666 <[email protected]>

* rerun 2

Signed-off-by: naruse666 <[email protected]>

---------

Signed-off-by: naruse666 <[email protected]>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
* wait more

Signed-off-by: naruse666 <[email protected]>

* fix: wait

Signed-off-by: naruse666 <[email protected]>

* rerun

Signed-off-by: naruse666 <[email protected]>

* rerun 2

Signed-off-by: naruse666 <[email protected]>

---------

Signed-off-by: naruse666 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants