Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/15884 #15911

Closed
wants to merge 3 commits into from
Closed

Feature/15884 #15911

wants to merge 3 commits into from

Conversation

nikzayn
Copy link
Contributor

@nikzayn nikzayn commented Oct 11, 2023

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • [x ] I have signed off all my commits as required by DCO
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@nikzayn nikzayn requested review from a team as code owners October 11, 2023 17:30
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f8f9ae9) 49.69% compared to head (d02d56c) 49.68%.

❗ Current head d02d56c differs from pull request most recent head 7a128c7. Consider uploading reports for the commit 7a128c7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #15911      +/-   ##
==========================================
- Coverage   49.69%   49.68%   -0.01%     
==========================================
  Files         267      267              
  Lines       46362    46362              
==========================================
- Hits        23039    23035       -4     
- Misses      21063    21066       +3     
- Partials     2260     2261       +1     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -339,7 +339,7 @@ spec:
- name: argocd-server
port: 80
- kind: Rule
match: Host(`argocd.example.com`) && Headers(`Content-Type`, `application/grpc`)
match: Host(`argocd.example.com`) && Header(`Content-Type`, `application/grpc`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the Traefik Rules, Headers seems to actually be correct

@blakepettersson
Copy link
Member

Thanks for your PR, but this seems to have already been handled by #15913, which came in just before yours 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants