Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add examples to --help output for remaining "get APPNAME" #15862

Merged
merged 15 commits into from
Oct 18, 2023
Merged

feat: Add examples to --help output for remaining "get APPNAME" #15862

merged 15 commits into from
Oct 18, 2023

Conversation

Ratangulati
Copy link
Contributor

@Ratangulati Ratangulati commented Oct 7, 2023 •
edited
Loading

I'm adding PR to address #15690 #L317

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@Ratangulati Ratangulati requested review from a team as code owners October 7, 2023 09:00
@codecov
Copy link

codecov bot commented Oct 7, 2023 •
edited
Loading

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (f93b2e4) 49.76% compared to head (ace3aec) 49.65%.
Report is 5 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #15862      +/-   ##
==========================================
- Coverage   49.76%   49.65%   -0.11%     
==========================================
  Files         267      267              
  Lines       46296    46391      +95     
==========================================
- Hits        23038    23036       -2     
- Misses      20998    21094      +96     
- Partials     2260     2261       +1
Files Coverage Δ
cmd/argocd/commands/app.go 20.61% <0.00%> (-0.80%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ratangulati Ratangulati force-pushed the app-get branch 3 times, most recently from c900a5d to 782cc32 Compare October 8, 2023 08:00
Ratangulati and others added 12 commits October 8, 2023 23:17
@Ratangulati
feat: Add examples to --help output for get APPNAME
3461816 
Signed-off-by: Ratan Gulati <[email protected]>
@Ratangulati
feat: Add examples to --help output for get APPNAME
6c0a89d 
Signed-off-by: Ratan Gulati <[email protected]>
@Ratangulati
Update app.go
825a41f 
Signed-off-by: Ratan Gulati <[email protected]>
@Ratangulati
Update argocd_app_get.md
0764751 
Signed-off-by: Ratan Gulati <[email protected]>
@Ratangulati
Update argocd_app_get.md
268f73f 
Signed-off-by: Ratan Gulati <[email protected]>
@Ratangulati
updated app.go
791b301 
Signed-off-by: Ratan Gulati <[email protected]>
@Ratangulati
Update app.go
87d5fe6 
Signed-off-by: Ratan Gulati <[email protected]>
@Ratangulati
Update argocd_app_get.md
d1d7a2a 
Signed-off-by: Ratan Gulati <[email protected]>
@Ratangulati
Update app.go
a203336 
Signed-off-by: Ratan Gulati <[email protected]>
@crenshaw-dev @Ratangulati
docs: clarify health inheritance (argoproj#15799)
ceab89b 
* docs: resource health inheritance

Signed-off-by: Michael Crenshaw <[email protected]>

* write more better

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Ratan Gulati <[email protected]>
@Ratangulati
updated file
551c77b 
Signed-off-by: Ratan Gulati <[email protected]>
@Ratangulati
Update app.go
f198abc 
Signed-off-by: Ratan Gulati <[email protected]>
@Ratangulati Ratangulati closed this Oct 9, 2023
@Ratangulati Ratangulati reopened this Oct 9, 2023
@Ratangulati
Copy link
Contributor Author

Ratangulati commented Oct 10, 2023 •
edited
Loading

@ishitasequeira @crenshaw-dev
Please review my PR.

ishitasequeira
ishitasequeira requested changes Oct 10, 2023
View reviewed changes
cmd/argocd/commands/app.go Outdated Show resolved Hide resolved
@Ratangulati
updated get-APPNAME
48ef49c 
Signed-off-by: Ratan Gulati <[email protected]>
@Ratangulati
updated get-APPNAME
ace3aec 
Signed-off-by: Ratan Gulati <[email protected]>
ishitasequeira
ishitasequeira approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ishitasequeira ishitasequeira merged commit 5b07a12 into argoproj:master Oct 18, 2023
@Ratangulati Ratangulati deleted the app-get branch October 18, 2023 04:27
ymktmk pushed a commit to ymktmk/argo-cd that referenced this pull request Oct 29, 2023
@Ratangulati @crenshaw-dev @ymktmk
feat: Add examples to --help output for remaining "get APPNAME" (argo…
d95be3a 
…proj#15862)

* feat: Add examples to --help output for get APPNAME

Signed-off-by: Ratan Gulati <[email protected]>

* feat: Add examples to --help output for get APPNAME

Signed-off-by: Ratan Gulati <[email protected]>

* Update app.go

Signed-off-by: Ratan Gulati <[email protected]>

* Update argocd_app_get.md

Signed-off-by: Ratan Gulati <[email protected]>

* Update argocd_app_get.md

Signed-off-by: Ratan Gulati <[email protected]>

* updated app.go

Signed-off-by: Ratan Gulati <[email protected]>

* Update app.go

Signed-off-by: Ratan Gulati <[email protected]>

* Update argocd_app_get.md

Signed-off-by: Ratan Gulati <[email protected]>

* Update app.go

Signed-off-by: Ratan Gulati <[email protected]>

* docs: clarify health inheritance (argoproj#15799)

* docs: resource health inheritance

Signed-off-by: Michael Crenshaw <[email protected]>

* write more better

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Ratan Gulati <[email protected]>

* updated file

Signed-off-by: Ratan Gulati <[email protected]>

* Update app.go

Signed-off-by: Ratan Gulati <[email protected]>

* updated get-APPNAME

Signed-off-by: Ratan Gulati <[email protected]>

* updated get-APPNAME

Signed-off-by: Ratan Gulati <[email protected]>

---------

Signed-off-by: Ratan Gulati <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
jmilic1 pushed a commit to jmilic1/argo-cd that referenced this pull request Nov 13, 2023
@Ratangulati @crenshaw-dev @jmilic1
feat: Add examples to --help output for remaining "get APPNAME" (argo…
6e26a32 
…proj#15862)

* feat: Add examples to --help output for get APPNAME

Signed-off-by: Ratan Gulati <[email protected]>

* feat: Add examples to --help output for get APPNAME

Signed-off-by: Ratan Gulati <[email protected]>

* Update app.go

Signed-off-by: Ratan Gulati <[email protected]>

* Update argocd_app_get.md

Signed-off-by: Ratan Gulati <[email protected]>

* Update argocd_app_get.md

Signed-off-by: Ratan Gulati <[email protected]>

* updated app.go

Signed-off-by: Ratan Gulati <[email protected]>

* Update app.go

Signed-off-by: Ratan Gulati <[email protected]>

* Update argocd_app_get.md

Signed-off-by: Ratan Gulati <[email protected]>

* Update app.go

Signed-off-by: Ratan Gulati <[email protected]>

* docs: clarify health inheritance (argoproj#15799)

* docs: resource health inheritance

Signed-off-by: Michael Crenshaw <[email protected]>

* write more better

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Ratan Gulati <[email protected]>

* updated file

Signed-off-by: Ratan Gulati <[email protected]>

* Update app.go

Signed-off-by: Ratan Gulati <[email protected]>

* updated get-APPNAME

Signed-off-by: Ratan Gulati <[email protected]>

* updated get-APPNAME

Signed-off-by: Ratan Gulati <[email protected]>

---------

Signed-off-by: Ratan Gulati <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: jmilic1 <[email protected]>
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
@Ratangulati @crenshaw-dev @vladfr
feat: Add examples to --help output for remaining "get APPNAME" (argo…
082b5ee 
…proj#15862)

* feat: Add examples to --help output for get APPNAME

Signed-off-by: Ratan Gulati <[email protected]>

* feat: Add examples to --help output for get APPNAME

Signed-off-by: Ratan Gulati <[email protected]>

* Update app.go

Signed-off-by: Ratan Gulati <[email protected]>

* Update argocd_app_get.md

Signed-off-by: Ratan Gulati <[email protected]>

* Update argocd_app_get.md

Signed-off-by: Ratan Gulati <[email protected]>

* updated app.go

Signed-off-by: Ratan Gulati <[email protected]>

* Update app.go

Signed-off-by: Ratan Gulati <[email protected]>

* Update argocd_app_get.md

Signed-off-by: Ratan Gulati <[email protected]>

* Update app.go

Signed-off-by: Ratan Gulati <[email protected]>

* docs: clarify health inheritance (argoproj#15799)

* docs: resource health inheritance

Signed-off-by: Michael Crenshaw <[email protected]>

* write more better

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Ratan Gulati <[email protected]>

* updated file

Signed-off-by: Ratan Gulati <[email protected]>

* Update app.go

Signed-off-by: Ratan Gulati <[email protected]>

* updated get-APPNAME

Signed-off-by: Ratan Gulati <[email protected]>

* updated get-APPNAME

Signed-off-by: Ratan Gulati <[email protected]>

---------

Signed-off-by: Ratan Gulati <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
@Ratangulati @crenshaw-dev @tesla59
feat: Add examples to --help output for remaining "get APPNAME" (argo…
1e651f4 
…proj#15862)

* feat: Add examples to --help output for get APPNAME

Signed-off-by: Ratan Gulati <[email protected]>

* feat: Add examples to --help output for get APPNAME

Signed-off-by: Ratan Gulati <[email protected]>

* Update app.go

Signed-off-by: Ratan Gulati <[email protected]>

* Update argocd_app_get.md

Signed-off-by: Ratan Gulati <[email protected]>

* Update argocd_app_get.md

Signed-off-by: Ratan Gulati <[email protected]>

* updated app.go

Signed-off-by: Ratan Gulati <[email protected]>

* Update app.go

Signed-off-by: Ratan Gulati <[email protected]>

* Update argocd_app_get.md

Signed-off-by: Ratan Gulati <[email protected]>

* Update app.go

Signed-off-by: Ratan Gulati <[email protected]>

* docs: clarify health inheritance (argoproj#15799)

* docs: resource health inheritance

Signed-off-by: Michael Crenshaw <[email protected]>

* write more better

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Ratan Gulati <[email protected]>

* updated file

Signed-off-by: Ratan Gulati <[email protected]>

* Update app.go

Signed-off-by: Ratan Gulati <[email protected]>

* updated get-APPNAME

Signed-off-by: Ratan Gulati <[email protected]>

* updated get-APPNAME

Signed-off-by: Ratan Gulati <[email protected]>

---------

Signed-off-by: Ratan Gulati <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
lukaszgyg pushed a commit to lukaszgyg/argo-cd that referenced this pull request Jan 12, 2024
@Ratangulati @crenshaw-dev @lukaszgyg
feat: Add examples to --help output for remaining "get APPNAME" (argo…
206f692 
…proj#15862)

* feat: Add examples to --help output for get APPNAME

Signed-off-by: Ratan Gulati <[email protected]>

* feat: Add examples to --help output for get APPNAME

Signed-off-by: Ratan Gulati <[email protected]>

* Update app.go

Signed-off-by: Ratan Gulati <[email protected]>

* Update argocd_app_get.md

Signed-off-by: Ratan Gulati <[email protected]>

* Update argocd_app_get.md

Signed-off-by: Ratan Gulati <[email protected]>

* updated app.go

Signed-off-by: Ratan Gulati <[email protected]>

* Update app.go

Signed-off-by: Ratan Gulati <[email protected]>

* Update argocd_app_get.md

Signed-off-by: Ratan Gulati <[email protected]>

* Update app.go

Signed-off-by: Ratan Gulati <[email protected]>

* docs: clarify health inheritance (argoproj#15799)

* docs: resource health inheritance

Signed-off-by: Michael Crenshaw <[email protected]>

* write more better

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Ratan Gulati <[email protected]>

* updated file

Signed-off-by: Ratan Gulati <[email protected]>

* Update app.go

Signed-off-by: Ratan Gulati <[email protected]>

* updated get-APPNAME

Signed-off-by: Ratan Gulati <[email protected]>

* updated get-APPNAME

Signed-off-by: Ratan Gulati <[email protected]>

---------

Signed-off-by: Ratan Gulati <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
@Ratangulati @crenshaw-dev @Hariharasuthan99
feat: Add examples to --help output for remaining "get APPNAME" (argo…
6b7b08f 
…proj#15862)

* feat: Add examples to --help output for get APPNAME

Signed-off-by: Ratan Gulati <[email protected]>

* feat: Add examples to --help output for get APPNAME

Signed-off-by: Ratan Gulati <[email protected]>

* Update app.go

Signed-off-by: Ratan Gulati <[email protected]>

* Update argocd_app_get.md

Signed-off-by: Ratan Gulati <[email protected]>

* Update argocd_app_get.md

Signed-off-by: Ratan Gulati <[email protected]>

* updated app.go

Signed-off-by: Ratan Gulati <[email protected]>

* Update app.go

Signed-off-by: Ratan Gulati <[email protected]>

* Update argocd_app_get.md

Signed-off-by: Ratan Gulati <[email protected]>

* Update app.go

Signed-off-by: Ratan Gulati <[email protected]>

* docs: clarify health inheritance (argoproj#15799)

* docs: resource health inheritance

Signed-off-by: Michael Crenshaw <[email protected]>

* write more better

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Ratan Gulati <[email protected]>

* updated file

Signed-off-by: Ratan Gulati <[email protected]>

* Update app.go

Signed-off-by: Ratan Gulati <[email protected]>

* updated get-APPNAME

Signed-off-by: Ratan Gulati <[email protected]>

* updated get-APPNAME

Signed-off-by: Ratan Gulati <[email protected]>

---------

Signed-off-by: Ratan Gulati <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishitasequeira ishitasequeira ishitasequeira approved these changes

Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ratangulati @ishitasequeira @crenshaw-dev