-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): adding gpg examples (#15690) #15844
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #15844 +/- ##
==========================================
- Coverage 49.56% 49.54% -0.02%
==========================================
Files 269 269
Lines 46668 46680 +12
==========================================
- Hits 23131 23128 -3
- Misses 21263 21277 +14
- Partials 2274 2275 +1
☔ View full report in Codecov by Sentry. |
I am not able to figure out why this check is failing https://github.com/argoproj/argo-cd/actions/runs/6430691978/job/17462132638?pr=15844 |
You should be able to either run |
Thanks @blakepettersson For clearing this for me |
|
||
# Add a GPG public key to the server's key | ||
argocd gpg add --key <GPG_PUBLIC_KEY> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you either un-indent the string or use the templates.Examples
function to correct indentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I have done the changes for all .md
files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I run make clidocsgen
command then it is adding the un-indentation to the string
So is it necessary to run make clidocsgen
in this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to remove the indentation in the .go files and then run make clidocsgen
.
So,
Example: `
# Remove a GPG public key from the server's key using its key ID
argocd gpg rm <KEYID>
`,
Looks weird, but it gets the job done :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it! Thanks for the suggestions
I hope all checks will pass now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! Can you un-indent the examples for all 4 commands?
@crenshaw-dev If I manually run |
6b3e3d8
to
614a925
Compare
Signed-off-by: Gaurang Kudale <[email protected]>
Signed-off-by: Gaurang Kudale <[email protected]>
Signed-off-by: Gaurang Kudale <[email protected]>
…[email protected] Signed-off-by: Gaurang Kudale <[email protected]>
…[email protected] Signed-off-by: Gaurang Kudale <[email protected]>
…[email protected] Signed-off-by: Gaurang Kudale <[email protected]>
…[email protected] Signed-off-by: Gaurang Kudale <[email protected]>
…[email protected] Signed-off-by: Gaurang Kudale <[email protected]>
614a925
to
c95add4
Compare
Signed-off-by: Michael Crenshaw <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gaurangkudale please resolve the merge conflicts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gaurangkudale would you mind resolving conflicts?
adding logout examples for improvement #15690
Checklist: