Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add example to argocd relogin command #15823

Closed
wants to merge 10 commits into from
Closed

feat: Add example to argocd relogin command #15823

wants to merge 10 commits into from

Conversation

chiranjeevir-git
Copy link
Contributor

@chiranjeevir-git chiranjeevir-git commented Oct 5, 2023

Hi team,
With this PR I would like to address the missing examples for the command "argocd relogin" for issue #15690.

var command = &cobra.Command{

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@chiranjeevir-git chiranjeevir-git requested a review from a team as a code owner October 5, 2023 09:15
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (401a7f1) 49.90% compared to head (cebbf74) 49.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #15823   +/-   ##
=======================================
  Coverage   49.90%   49.91%           
=======================================
  Files         266      266           
  Lines       46092    46091    -1     
=======================================
+ Hits        23003    23005    +2     
+ Misses      20830    20828    -2     
+ Partials     2259     2258    -1     
Files Coverage Δ
cmd/argocd/commands/relogin.go 17.91% <100.00%> (-1.21%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chiranjeevir-git chiranjeevir-git requested a review from a team as a code owner October 5, 2023 09:48
cr001 and others added 7 commits October 5, 2023 17:38
Signed-off-by: cr001 <[email protected]>
Signed-off-by: chiranjeevi r <[email protected]>
Signed-off-by: cr001 <[email protected]>
Signed-off-by: chiranjeevi r <[email protected]>
Signed-off-by: cr001 <[email protected]>
Signed-off-by: chiranjeevi r <[email protected]>
Signed-off-by: cr001 <[email protected]>
Signed-off-by: chiranjeevi r <[email protected]>
Signed-off-by: cr001 <[email protected]>
Signed-off-by: chiranjeevi r <[email protected]>
Signed-off-by: cr001 <[email protected]>
Signed-off-by: chiranjeevi r <[email protected]>
@crenshaw-dev
Copy link
Member

@chiranjeevir-git another PR touched the same file. Can you rebase and push?

@chiranjeevir-git
Copy link
Contributor Author

chiranjeevir-git commented Oct 6, 2023

@crenshaw-dev i have rebased and pushed new changes with more examples and commands
will this PR be considered for merging ?

@chiranjeevir-git chiranjeevir-git closed this by deleting the head repository Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants