Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(bounty): proposal for feature to hide annotations on secrets in UI #15699

Merged
merged 3 commits into from
Oct 24, 2023
Merged

docs(bounty): proposal for feature to hide annotations on secrets in UI #15699

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44f5b1c
docs(bounty): proposal for feature to hide annotations on secrets in …
crenshaw-dev Sep 27, 2023
61aa74d
fix file location
crenshaw-dev Oct 6, 2023
1406f72
Merge branch 'master' into bounty-secret-annotation-proposal
todaywasawesome Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions docs/proposals/feature-bounties/hide-annotations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# Proposal: Allow Hiding Certain Annotations in the Argo CD Web UI

Based on this issue: https://github.com/argoproj/argo-cd/issues/15693

Award amount: $100

## Solution

!!! note
This is the proposed solution. The accepted PR may differ from this proposal.

Add a new config item in argocd-cm:

```yaml
hide.secret.annotations: |
- openshift.io/token-secret.value
```

This will hide the `openshift.io/token-secret.value` annotation from the UI. Behind the scenes, it would likely work the
same way as the `last-applied-configuration` annotation hiding works: https://github.com/argoproj/gitops-engine/blob/b0fffe419a0f0a40f9f2c0b6346b752ed6537385/pkg/diff/diff.go#L897

I considered whether we'd want to support hiding things besides annotations and in resources besides secrets, but
having reviewed existing issues, I think this narrow feature is sufficient.
Loading