-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cmp): cmp parameter to enable git creds to be shared (#8820) #15107
feat(cmp): cmp parameter to enable git creds to be shared (#8820) #15107
Conversation
272a25c
to
c468169
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #15107 +/- ##
=========================================
Coverage ? 55.20%
=========================================
Files ? 324
Lines ? 55128
Branches ? 0
=========================================
Hits ? 30434
Misses ? 22089
Partials ? 2605 ☔ View full report in Codecov by Sentry. |
51de757
to
fc9665b
Compare
Resolves #8820 |
03cb53e
to
0a01c3f
Compare
0a01c3f
to
cbbe600
Compare
4b84e06
to
5309b84
Compare
3de5677
to
fcf2139
Compare
fcf2139
to
95f768c
Compare
The key difference between this implementation and what was reverted in #9105 is twofold:
|
f4a31e2
to
7c0fcc8
Compare
7c0fcc8
to
e9091cf
Compare
a2f14e7
to
59f70c3
Compare
@pasha-codefresh @crenshaw-dev This is probably the closest thing we have to a resolution for #8820. I think it's critical that ArgoCD plugins can access the ArgoCD credentials in some safe way, so I would appreciate your comments on this PRs approach. |
c9d1c3a
to
c707616
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a quick glance, just a few small things
c707616
to
d51b30d
Compare
c01cb64
to
7335bf1
Compare
@crenshaw-dev that test is passing now |
1ac42f1
to
c800900
Compare
@crenshaw-dev would you be able to provide a pass back through this or remove the blocking review? |
c800900
to
4338fb1
Compare
We've had a good back and forth on this PR and I'm going to leave it at this point. I've regularly rebased the PR to the latest master to ensure that the tests are in a healthy state with recent changes and this will be the last time I do it until I get constructive feedback. If other folks want to take up moving this forward, the PR should be in a good place to support this. I understand the constraints of managing a large open source project like this one, but I need to take my eye off this PR for the time being. |
5404e51
to
5105d61
Compare
687449d
to
c3cfe3b
Compare
…e plugin Signed-off-by: jmcshane <[email protected]>
c3cfe3b
to
eb35009
Compare
@crenshaw-dev that test is passing, the failed integration tests were related to flakiness on dev. Can this be merged? |
…r to the plugin (argoproj#15107) Signed-off-by: jmcshane <[email protected]> Signed-off-by: Adrian Aneci <[email protected]>
Closes #8820
Closes #7995
Checklist:
This is a work in progress at this time to get input.
Fixes #14998