fix(ui): prevent app panel to open on app direct link click #15040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslafy-z
force-pushed
the
aslafy-z-patch-1
branch
5 times, most recently
from
a9eaaa1 to
bd0a76a
Compare
|
@aslafy-z Looks like CI is failing due to UI linter, to fix you can lint with |
aslafy-z
force-pushed
the
aslafy-z-patch-1
branch
2 times, most recently
from
1158444 to
efb6665
Compare
|
@rbreeze I just fixed the lint! :) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15040 +/- ##
=======================================
Coverage 49.55% 49.55%
=======================================
Files 269 269
Lines 46891 46891
=======================================
Hits 23236 23236
Misses 21374 21374
Partials 2281 2281 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Zadkiel Aharonian <[email protected]>
aslafy-z
force-pushed
the
aslafy-z-patch-1
branch
from
efb6665 to
b61bab5
Compare
|
@rbreeze any chance this PR gets merged some day? |
|
/cherry-pick release-2.9 |
|
/cherry-pick release-2.8 |
|
/cherry-pick release-2.7 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Nov 1, 2023
Signed-off-by: Zadkiel Aharonian <[email protected]>
|
/cherry-pick release-2.6 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Nov 1, 2023
Signed-off-by: Zadkiel Aharonian <[email protected]>
|
Cherry-pick failed with |
|
Cherry-pick failed with |
crenshaw-dev
pushed a commit
that referenced
this pull request
Nov 1, 2023
…16201) Signed-off-by: Zadkiel Aharonian <[email protected]> Co-authored-by: Zadkiel Aharonian <[email protected]>
crenshaw-dev
pushed a commit
that referenced
this pull request
Nov 1, 2023
…16202) Signed-off-by: Zadkiel Aharonian <[email protected]> Co-authored-by: Zadkiel Aharonian <[email protected]>
jmilic1
pushed a commit
to jmilic1/argo-cd
that referenced
this pull request
Nov 13, 2023
…#15040) Signed-off-by: Zadkiel Aharonian <[email protected]> Signed-off-by: jmilic1 <[email protected]>
vladfr
pushed a commit
to vladfr/argo-cd
that referenced
this pull request
Dec 13, 2023
…#15040) Signed-off-by: Zadkiel Aharonian <[email protected]>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
…#15040) Signed-off-by: Zadkiel Aharonian <[email protected]>
lyda
pushed a commit
to lyda/argo-cd
that referenced
this pull request
Mar 28, 2024
…#15040) Signed-off-by: Zadkiel Aharonian <[email protected]> Signed-off-by: Kevin Lyda <[email protected]>
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
…#15040) Signed-off-by: Zadkiel Aharonian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent opening of Application details panel on "Open application" link click.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Please see Contribution FAQs if you have questions about your pull-request.