Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Print in-cluster svr addr disabled warning when server starts #14683

Merged
merged 3 commits into from
Jul 24, 2023

Conversation

terrytangyuan
Copy link
Member

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

terrytangyuan and others added 3 commits July 24, 2023 14:43
…alization (argoproj#14539)

* chore: Print in-cluster svr addr disabled warning during ArgoDB initialization

Signed-off-by: Yuan Tang <[email protected]>

* fix: undo a change

Signed-off-by: Yuan Tang <[email protected]>

* chore: move to a function

Signed-off-by: Yuan Tang <[email protected]>

* chore: rename

Signed-off-by: Yuan Tang <[email protected]>

---------

Signed-off-by: Yuan Tang <[email protected]>
…rgoproj#14553)

* chore: Print in-cluster svr addr disabled warning when server starts

Signed-off-by: Yuan Tang <[email protected]>

* fix: mock

Signed-off-by: Yuan Tang <[email protected]>

* no interface change

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Yuan Tang <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 38.18% and project coverage change: -0.03 ⚠️

Comparison is base (2fa12c8) 47.64% compared to head (d28bfff) 47.62%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-2.5   #14683      +/-   ##
===============================================
- Coverage        47.64%   47.62%   -0.03%     
===============================================
  Files              240      240              
  Lines            39886    39928      +42     
===============================================
+ Hits             19005    19016      +11     
- Misses           18927    18952      +25     
- Partials          1954     1960       +6     
Impacted Files Coverage Δ
server/server.go 54.57% <32.60%> (-1.28%) ⬇️
util/db/cluster.go 59.23% <66.66%> (-0.26%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@crenshaw-dev crenshaw-dev merged commit 74600fc into argoproj:release-2.5 Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants