-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update SLSA verification commands #14437
Conversation
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
Let me know if there's something to do to fix pre-submits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@laurentsimon Thank you so much for the changes, they look great. LGTM! Just one request since this is a docs change. I appreciate the update in the GO dependencies, but could we do this in a separate PR? We will likely cherry-pick this back to our release-2.7
branch.
oops, totally. Was not supposed to be in the PR. I'll revert. |
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks again!
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #14437 +/- ##
==========================================
- Coverage 49.73% 49.72% -0.01%
==========================================
Files 261 261
Lines 44705 44705
==========================================
- Hits 22234 22230 -4
- Misses 20284 20287 +3
- Partials 2187 2188 +1 ☔ View full report in Codecov by Sentry. |
/cherry-pick release-2.8 |
/cherry-pick release-2.7 |
* update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> --------- Signed-off-by: laurentsimon <[email protected]>
* update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> --------- Signed-off-by: laurentsimon <[email protected]>
* update * update * update * update * update * update * update --------- Signed-off-by: laurentsimon <[email protected]> Co-authored-by: laurentsimon <[email protected]>
* update * update * update * update * update * update * update --------- Signed-off-by: laurentsimon <[email protected]> Co-authored-by: laurentsimon <[email protected]>
) * update * update * update * update * update * update * update --------- Signed-off-by: laurentsimon <[email protected]> Co-authored-by: laurentsimon <[email protected]> Signed-off-by: schakrad <[email protected]>
* update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> --------- Signed-off-by: laurentsimon <[email protected]>
* update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> * update Signed-off-by: laurentsimon <[email protected]> --------- Signed-off-by: laurentsimon <[email protected]>
closes #14431
Checklist:
Please see Contribution FAQs if you have questions about your pull-request.